bug#46625: closed (tramp-test33-environment-variables fails)

[GNU bug Tracking System]

Your message dated Fri, 19 Feb 2021 09:25:48 +0100
with message-id <87blcg8nw3.fsf@gmx.de>
and subject line Re: bug#46625: tramp-test33-environment-variables fails
has caused the debbugs.gnu.org bug report #46625,
regarding tramp-test33-environment-variables fails
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
46625: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=46625
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> tramp-test33-environment-variables fails
>
>
>
>
> Date: 
>
> Thu, 18 Feb 2021 17:03:12 -0500
>
>
>
>
> User-agent: 
>
> Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
>
>
>
>
> Package: emacs
> Severity: minor
> Version: 28.0.50
>
> tramp-test33-environment-variables fails on hydra.nixos since
> e5f50f32f76bab2607d77f0dc51cf81ec0c1e232.
>
> It seems to me that:
>
> (string-match-p (regexp-quote envvar) "printenv")
>
> isn't a robust way to test if ENVVAR is (not) set, because it can
> falsely match on $_=ENVVAR.
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#46625: tramp-test33-environment-variables fails
>
>
>
>
> Date: 
>
> Fri, 19 Feb 2021 09:25:48 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
>
>
>
>
> Glenn Morris <rgm@gnu.org> writes:
>
> Hi Glenn,
>
> > tramp-test33-environment-variables fails on hydra.nixos since
> > e5f50f32f76bab2607d77f0dc51cf81ec0c1e232.
> >
> > It seems to me that:
> >
> > (string-match-p (regexp-quote envvar) "printenv")
> >
> > isn't a robust way to test if ENVVAR is (not) set, because it can
> > falsely match on $_=ENVVAR.
>
> Thanks for the report. I've changed the way how Tramp suppresses unused
> environment variables, unfortunately this new problem doesn't occur when
> I run this test locally. Likely, it depends on the shell flavor /bin/sh
> is pointing too.
>
> Fixed and pushed, closing the bug.
>
> Best regards, Michael.
>
>
> --- End Message ---