bug#46391: closed ([PATCH 0/1] Canonicalize-path load-path option)

[GNU bug Tracking System]

Your message dated Wed, 24 Feb 2021 23:46:59 +0100
with message-id <87blc92ie4.fsf@gnu.org>
and subject line Re: bug#46391: [PATCH 0/1] Canonicalize-path load-path option
has caused the debbugs.gnu.org bug report #46391,
regarding [PATCH 0/1] Canonicalize-path load-path option
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
46391: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=46391
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/1] Canonicalize-path load-path option
>
>
>
>
> Date: 
>
> Tue,  9 Feb 2021 01:40:11 +0100
>
>
>
>
> Hi,
>
> This fixes <https://bugs.gnu.org/46390>.
>
> The test suite does not check relative path for the load-path option.
> I do not know what is the best to add a test about that.
>
> Last, I remember discussions about absolute/relative path and I do not know
> if this 'canonicalize-path' addition is the best fix here.
>
>
> All the best,
> simon
>
>
> zimoun (1):
>   scripts: build: Fix relative load-path.
>
>  guix/scripts/build.scm | 16 +++++++++-------
>  1 file changed, 9 insertions(+), 7 deletions(-)
>
>
> base-commit: 4cd8bab7d4b345c5538b8d039d84a957df7a235f
> -- 
> 2.29.2
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#46391: [PATCH 0/1] Canonicalize-path load-path option
>
>
>
>
> Date: 
>
> Wed, 24 Feb 2021 23:46:59 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
>
>
>
>
> Hi!
>
> zimoun <zimon.toutoune@gmail.com> skribis:
>
> > This fixes <https://bugs.gnu.org/46390>.
> >
> > The test suite does not check relative path for the load-path option.
> > I do not know what is the best to add a test about that.
> >
> > Last, I remember discussions about absolute/relative path and I do not know
> > if this 'canonicalize-path' addition is the best fix here.
> >
> >
> > All the best,
> > simon
> >
> >
> > zimoun (1):
> >   scripts: build: Fix relative load-path.
> >
> >  guix/scripts/build.scm | 16 +++++++++-------
> >  1 file changed, 9 insertions(+), 7 deletions(-)
>
> I’m discovering this after having independently addreses #46390, sorry
> about that!  (Perhaps we should always send patches that fix bugs to the
> corresponding bug report rather than/in addition to guix-patches?)
>
> Let me know what you think.
>
> Thanks,
> Ludo’.
>
>
> --- End Message ---