bug#47004: closed (28.0.50; [PATCH] Use `pop-to-buffer-same-window' in `project-eshell')

[GNU bug Tracking System]

Your message dated Mon, 08 Mar 2021 12:59:53 +0100
with message-id <871rcp3lfq.fsf@runbox.com>
and subject line Re: bug#47004: 28.0.50; [PATCH] Use 
`pop-to-buffer-same-window' in `project-eshell'
has caused the debbugs.gnu.org bug report #47004,
regarding 28.0.50; [PATCH] Use `pop-to-buffer-same-window' in `project-eshell'
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
47004: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=47004
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 28.0.50; [PATCH] Use `pop-to-buffer-same-window' in `project-eshell'
>
>
>
>
> Date: 
>
> Mon, 08 Mar 2021 12:50:06 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (gnu/linux)
>
>
>
>
> Hi.
>
> Could `project-eshell' be changed to use `pop-to-buffer-same-window'
> instead of `pop-to-buffer' to match the behavior of `M-x eshell'?
>
> >From a7109bbf417a322a7066fcdc93e43ca457b236ff Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Simen=20Heggest=C3=B8yl?= <simenheg@gmail.com>
> Date: Mon, 8 Mar 2021 12:38:41 +0100
> Subject: [PATCH] Use `pop-to-buffer-same-window' in `project-eshell'
>
> * lisp/progmodes/project.el (project-eshell): Use
> `pop-to-buffer-same-window' instead of `pop-to-buffer' to match the
> behavior of `M-x eshell'.
> ---
>  lisp/progmodes/project.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
> index abe563bec0..d59da2496a 100644
> --- a/lisp/progmodes/project.el
> +++ b/lisp/progmodes/project.el
> @@ -924,7 +924,7 @@ project-eshell
>                    "-eshell*"))
>           (eshell-buffer (get-buffer eshell-buffer-name)))
>      (if (and eshell-buffer (not current-prefix-arg))
> -        (pop-to-buffer eshell-buffer)
> +        (pop-to-buffer-same-window eshell-buffer)
>        (eshell t))))
>  
>  ;;;###autoload
> -- 
> 2.30.1
>
> -- Simen
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#47004: 28.0.50; [PATCH] Use `pop-to-buffer-same-window' in `project-eshell'
>
>
>
>
> Date: 
>
> Mon, 08 Mar 2021 12:59:53 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (gnu/linux)
>
>
>
>
> That was quick.
>
> Dmitry Gutov <dgutov@yandex.ru> writes:
>
> > On 08.03.2021 13:50, Simen Heggestøyl wrote:
> >> Could `project-eshell' be changed to use `pop-to-buffer-same-window'
> >> instead of `pop-to-buffer' to match the behavior of `M-x eshell'?
> >
> > Sure, please go ahead.
>
> Went ahead.
>
> Thanks!
>
> -- Simen
>
>
> --- End Message ---