bug#47540: closed ([PATCH] gnu: Add prips.)

[GNU bug Tracking System]

Your message dated Mon, 12 Apr 2021 12:47:41 +0200
with message-id <87h7kbrd82.fsf_-_@gnu.org>
and subject line Re: bug#47540: [PATCH] gnu: Add prips.
has caused the debbugs.gnu.org bug report #47540,
regarding [PATCH] gnu: Add prips.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
47540: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=47540
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] gnu: Add prips. Date: Thu, 01 Apr 2021 15:11:56 +0200

From 22cc953d3e663bb842d5a0b970577a3d54f6fef1 Mon Sep 17 00:00:00 2001
From: methuselah-0 <david.larsson@selfhosted.xyz>
Date: Thu, 1 Apr 2021 15:10:45 +0200
Subject: [PATCH] gnu: Add prips.

* gnu/packages/admin.scm (prips): New variable.
---
 gnu/packages/admin.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index df7973395d..f6cb62a568 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -39,6 +39,7 @@
 ;;; Copyright © 2021 Stefan Reichör <stefan@xsteve.at>
 ;;; Copyright © 2021 qblade <qblade@protonmail.com>
 ;;; Copyright © 2021 Hyunseok Kim <lasnesne@lagunposprasihopre.org>
+;;; Copyright © 2021 David Larsson <david.larsson@selfhosted.xyz>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;

@@ -1019,6 +1020,39 @@ recursive runs on the generated subnets. (also IPv6)

 @end itemize\n")
     (license license:bsd-3)))

+(define-public prips
+  (package
+    (name "prips")
+    (version "1.1.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://devel.ringlet.net/files/sys/";
+                           name "/" name "-" version ".tar.xz"))
+       (sha256

+ (base32 "1a33vbl4w603mk6mm5r3vhk87fy3dfk5wdpch0yd3ncbkg3fmvqn"))))

+    (build-system gnu-build-system)
+    (arguments
+     '(#:make-flags (list "CC=gcc")
+       #:phases (modify-phases
+                    %standard-phases
+                  (delete 'configure)
+                  (delete 'check)
+                  (replace 'install
+                    (lambda _
+                      (let*
+                          ((bin-dir  (string-append %output "/bin"))
+                           (bin-file (string-append bin-dir "/prips")))
+                        (mkdir-p bin-dir)
+                        (copy-file "prips" bin-file)
+                        (chmod bin-file #o700)))))))
+    (synopsis "Tool that prints the IP addresses in a given range")
+    (description "Prips can be used to print all of the IP addresses in
+ a given range.  This allows the enhancement of tools only work
+ on one host at a time (e.g. whois).")
+    (home-page "https://devel.ringlet.net/sysutils/prips/";)
+    (license license:gpl2)))
+
 (define-public alive
   (package
     (name "alive")
--
2.30.2

0001-gnu-Add-prips.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#47540: [PATCH] gnu: Add prips.
>
>
>
>
> Date: 
>
> Mon, 12 Apr 2021 12:47:41 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
>
>
>
>
> Hi,
>
> david larsson <david.larsson@selfhosted.xyz> skribis:
>
> > From 85cf7b9d22801d9b3bac8956b358fce4c32dcb4c Mon Sep 17 00:00:00 2001
> > From: methuselah-0 <david.larsson@selfhosted.xyz>
> > Date: Thu, 8 Apr 2021 21:26:23 +0200
> > Subject: [PATCH] gnu: Add prips.
> >
> > gnu/packages/admin.scm (prips): New variable.
>
> [...]
>
> > +                  (replace 'install
> > +                    (lambda _
> > +                      (let*
> > +                          ((bin-dir  (string-append %output "/bin"))
> > +                           (bin-file (string-append bin-dir "/prips")))
> > +                        (mkdir-p bin-dir)
> > +                        (copy-file "prips" bin-file)
> > +                        (chmod bin-file #o600)))))))
>
> That installed a non-executable file.  I fixed this with the patch
> below, which also make the style more consistent.
>
> Thanks David, and thanks Maxime for the review!
>
> Ludo’.
>
> diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
> index f3e8774b75..512ac320e6 100644
> --- a/gnu/packages/admin.scm
> +++ b/gnu/packages/admin.scm
> @@ -1070,13 +1070,10 @@ recursive runs on the generated subnets.  (also IPv6)
>         #:phases (modify-phases %standard-phases
>                    (delete 'configure)
>                    (replace 'install
> -                    (lambda _
> -                      (let*
> -                          ((bin-dir  (string-append %output "/bin"))
> -                           (bin-file (string-append bin-dir "/prips")))
> -                        (mkdir-p bin-dir)
> -                        (copy-file "prips" bin-file)
> -                        (chmod bin-file #o600)))))))
> +                    (lambda* (#:key outputs #:allow-other-keys)
> +                      (let ((out (assoc-ref outputs "out")))
> +                        (install-file "prips"
> +                                      (string-append out "/bin"))))))))
>      (native-inputs `(("perl-test-harness" ,perl-test-harness)))
>      (synopsis "Tool that prints the IP addresses in a given range")
>      (description "Prips can be used to print all of the IP addresses in
>
> --- End Message ---