bug#47704: closed ([PATCH] services: mysql: Add extra-environment as configuration option.)

[GNU bug Tracking System]

Your message dated Tue, 13 Apr 2021 18:58:57 +0200
with message-id 
<7a570acae3d60b16e34a89097d801876d5951f4e.camel@student.tugraz.at>
and subject line Re: [bug#47704] [PATCH] services: mysql: Add extra-environment 
as configuration option.
has caused the debbugs.gnu.org bug report #47704,
regarding [PATCH] services: mysql: Add extra-environment as configuration 
option.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
47704: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=47704
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] services: mysql: Add extra-environment as configuration option. Date: Sun, 11 Apr 2021 10:44:43 +0200

Hi!

This patch is needed for the Galera add-on to MariaDB, which runs some scripts like for example wsrep_sst_rsync that needs access to additional binaries in PATH.

I tested the patch with (and without) below snippets to the mysql-service in my config.scm and successfully connected to a MariaDB/Galera cluster.

I ran these commands to test:

guix pull --url=/home/user1/src/guix --profile=/tmp/guix.master --disable-authentication --allow-downgrades ; GUIX_PROFILE="/tmp/guix.master" ; . "$GUIX_PROFILE/etc/profile" ; guix system reconfigure config.scm --fallback --allow-downgrades

------------------------------------------------------------------

(extra-environment #~(list (string-append "PATH=/usr/bin:/bin:" #$rsync "/bin:" #$coreutils "/bin:" #$gawk "/bin:" #$grep "/bin:" #$mariadb "/bin:" #$iproute "/sbin:" "/run/setuid-programs:/run/current-system/profile/bin:/run/current-system/profile/sbin" ) (string-append "SHELL=" #$bash) "USER=mysql" "SSL_CERT_FILE=/etc/ssl/certs/ca-certificates.crt" "SSL_CERT_DIR=/run/current-system/profile/etc/ssl/certs"))

(extra-content #~(string-append "log_error=/var/lib/mysql/log_error.log

# https://www.percona.com/blog/2017/07/26/what-is-innodb_autoinc_lock_mode-and-why-should-i-care/

binlog_format=ROW
default-storage-engine=innodb
innodb_autoinc_lock_mode=2

# Galera Provider Configuration
wsrep_on=ON
wsrep_provider=" #$galera "/lib/libgalera_smm.so

# Galera Cluster Configuration
wsrep_cluster_name=\"test_cluster\"
wsrep_cluster_address=\"gcomm://redacted,redacted\"

# according to https://galeracluster.com/library/documentation/mysql-wsrep-options.html # leaving it empty starts a new cluster, so you should immediately reconfigure again after doing this.

#wsrep_cluster_address=\"gcomm://\"

# Galera Synchronization Configuration
wsrep_sst_method=rsync

# Galera Node Configuration
wsrep_node_address=\"redacted\"
wsrep_node_name=\"librem13v3guixsd\""))
                               ))

------------------------------------------------------------------

Please someone also review [bug#47517] [PATCH] gnu: nginx: Enable stream module

which adds support for tcp loadbalancing that can be used to scale a MariaDB/Galera cluster.

Best regards,
David

0001-services-mysql-Add-extra-environment-as-configuratio.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#47704] [PATCH] services: mysql: Add extra-environment as configuration option.
>
>
>
>
> Date: 
>
> Tue, 13 Apr 2021 18:58:57 +0200
>
>
>
>
> User-agent: 
>
> Evolution 3.34.2 
>
>
>
>
> Am Montag, den 12.04.2021, 22:09 +0200 schrieb Maxime Devos:
> > I think your original patch is good to go into the git repo.  I'll
> > open a
> > separate bug report about ‘absolutising’ the binaries referred to
> > from the scripts.
> I've pushed this patch now, but let us still look for a smaller
> solution if applicable.  (That said, I'm not a mysql user and I'm happy
> to leave security stuff to lle_bout.)
>
> @david: Note, that I did not change the author, meaning it is committed
> as "methuselah-0 <david.larsson@selfhosted.xyz>" rather than 
> "david larsson <david.larsson@selfhosted.xyz>".  Since this patch is
> hopefully small enough to not require attribution, that is fine, but if
> you plan on making bigger changes, please consider setting your git up
> appropriately.
>
> Regards,
> Leo 
>
>
>
> --- End Message ---