bug#47478: closed (28.0.50; Provide customization option for nnimap-keepalive-timer)

[GNU bug Tracking System]

Your message dated Tue, 04 May 2021 16:35:09 -0700
with message-id <87sg323weq.fsf@ericabrahamsen.net>
and subject line Re: bug#47478: 28.0.50; Provide customization option for 
nnimap-keepalive-timer
has caused the debbugs.gnu.org bug report #47478,
regarding 28.0.50; Provide customization option for nnimap-keepalive-timer
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
47478: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=47478
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: 28.0.50; Provide customization option for nnimap-keepalive-timer Date: Mon, 29 Mar 2021 09:22:40 -0700 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Bob Newell requested the ability to customize the
`nnimap-keepalive-timer', and I've opened this bug report with a patch
that adds a new `nnimap-keepalive-times' customization option.

It lets you customize both function interval and period of inactivity,
or you can set it to nil to disable the keepalive altogether.

I also sneaked in a little extra change: since we provided the option to
use Dbus to close Gnus servers when your machine is going to sleep, I've
noticed that sometimes (more often than you'd think) I seem to be
sleeping the machine in between sending the keepalive NOOP and receiving
the response.

When the computer wakes, Emacs is hung while Gnus waits on an OK that
isn't coming, and I need to C-g to get out of it. I would have thought
this was a pretty small target to hit, particular since my imap servers
are all on this computer, but it happens quite often. So this patch also
lets `nnimap-streaming' to t around the keepalive command, so we don't
wait for the response. Semantically incorrect, but the effect is right.

If this is acceptable I can add a NEWS entry (and maybe the manual as
well?).

Eric

nnimap-keepalive-customization.diff
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#47478: 28.0.50; Provide customization option for nnimap-keepalive-timer
>
>
>
>
> Date: 
>
> Tue, 04 May 2021 16:35:09 -0700
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
>
>
>
>
> On 05/04/21 10:01 AM, Lars Ingebrigtsen wrote:
> > Eric Abrahamsen <eric@ericabrahamsen.net> writes:
> >
> >> +By default, nnimap will send occasional ``NOOP'' signals to the
> >> +server, to keep the connection alive.
> >
> > Perhaps this should say "sends a @samp{NOOP} (keepalive) command" to be
> > less obscure?
> >
> >> +keepalive command.  Set to nil to disable keepalive commands altogether.
> >
> > @code{nil}
> >
> > Otherwise, looks good to me.
>
> Thanks! Done and closing.
>
>
> --- End Message ---