--- Begin Message ---
|
Subject: |
[PATCH] gnu: xfce4-session: Add xset to propagated-inputs. |
|
Date: |
Tue, 4 May 2021 19:20:51 +1000 |
* gnu/packages/xfce.scm (xfce4-session):[propagated-inputs]: Add xset so
that xflock4 can turn off the monitor.
---
gnu/packages/xfce.scm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 9655d8ccf7..f1e40a94b8 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -718,6 +718,8 @@ your system in categories, so you can quickly find and
launch them.")
("libsm" ,libsm)
("libwnck" ,libwnck)
("libxfce4ui" ,libxfce4ui)))
+ (propagated-inputs
+ `(("xset" ,xset)))
(home-page "https://www.xfce.org/";)
(synopsis "Xfce session manager")
(description
--
2.31.1
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#48220: [PATCH] gnu: xfce4-session: Add xset to propagated-inputs. |
|
Date: |
Sat, 08 May 2021 12:23:21 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hi!
Brendan Tildesley <mail@brendan.scot> skribis:
[...]
>> However, my understanding is that the xset code is already a fallback:
>
>>
>> --8<---------------cut here---------------start------------->8---
>> # else run another access locking utility, if installed
>> for lock_cmd in \
>> "xlock -mode blank" \
>> "slock"
>> do
>> set -- $lock_cmd
>> if command -v -- $1 >/dev/null 2>&1; then
>> $lock_cmd >/dev/null 2>&1 &
>> # turn off display backlight:
>> xset dpms force off
>> exit
>> fi
>> done
>> --8<---------------cut here---------------end--------------->8---
>>
>> Probably we should ensure the first ‘for’ loop works as expected.
>> Perhaps we need to replace ‘xfce4-screensaver-command’ by its absolute
>> file name there.
>>
>
> Currently xfce4-screensaver is not installed in the xfce package at all by
> default,
> so it isn't used. I could add it, but for me it was glitchy/flickering and I
> would keep
> clearing the password as I was entering it so I couldn't log back in. It even
> does it
> in a VM. I do have a recent amd graphics card with proprietary linux though,
> my computer
> can't boot otherwise :(.
Hmm OK. We should address this in a separate issue.
> If you run guix environment --ad-hoc xfce4-screensaver
> then
> xfce4-screensaver &; xfce4-screensaver-command --lock
> does it work for you?
I get:
--8<---------------cut here---------------start------------->8---
$ xfce4-screensaver & xfce4-screensaver-command --lock
[1] 19108
** Message: 12:20:44.361: Screensaver is not running! Start xfce4-screensaver
first
--8<---------------cut here---------------end--------------->8---
… but I’m not running Xfce. I should prolly try in a VM.
> I'm not sure what is best, should we be maximal and include xfce4-screensaver
> in the xfce
> package, or be minimal and make people have to install it manually?
I’d lean towards including xfce4-screensaver, since that’s the intended
use of Xfce, but only once it actually works.
> From ed66cf50a3b9294effc8bbae04b0f2564bd55c10 Mon Sep 17 00:00:00 2001
> From: Brendan Tildesley <mail@brendan.scot>
> Date: Thu, 6 May 2021 12:34:55 +1000
> Subject: [PATCH] gnu: xfce4-session: Allow xflock4 to use xset.
>
> * gnu/packages/xfce.scm (xfce4-session):
> [inputs]: Add xset.
> [arguments]: Add a phase to use exact store path to xset in xflock4.
[...]
> + (add-after 'unpack 'patch-xflock
> + (lambda _
> + (substitute* "scripts/xflock4"
> + (("xset") (which "xset"))))))))
Applied after changing ‘which’ to refer to the “xset” input so that it
works correctly when cross-compiling.
Closing, and let’s discuss xfce4-screensaver separately!
Thanks,
Ludo’.
--- End Message ---