bug#29925: closed ([PATCH 3/5] guix package: Disable profile hooks on dry runs.)

[GNU bug Tracking System]

Your message dated Wed, 12 May 2021 19:12:01 +0800
with message-id 
<OSZP286MB06646499F30864E598E5BBF1A3529@OSZP286MB0664.JPNP286.PROD.OUTLOOK.COM>
and subject line Re: [PATCH 0/5] Optimize profile hooks
has caused the debbugs.gnu.org bug report #29925,
regarding [PATCH 3/5] guix package: Disable profile hooks on dry runs.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
29925: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29925
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 3/5] guix package: Disable profile hooks on dry runs.
>
>
>
>
> Date: 
>
> Mon,  1 Jan 2018 18:33:34 +0800
>
>
>
>
> Profile hooks will access the content of manifest inputs before return the
> profile derivation, disable them so we don't get inputs bulit on dry runs.
>
> * guix/scripts/package.scm (build-and-use-profile): Disable profile hooks when
> a dry-run parameter is given.
> ---
>  guix/scripts/package.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guix/scripts/package.scm b/guix/scripts/package.scm
> index 617e102d9..ce0031551 100644
> --- a/guix/scripts/package.scm
> +++ b/guix/scripts/package.scm
> @@ -203,7 +203,7 @@ specified in MANIFEST, a manifest object."
>  
>    (let* ((prof-drv (run-with-store store
>                       (profile-derivation manifest
> -                                         #:hooks (if bootstrap?
> +                                         #:hooks (if (or bootstrap? dry-run?)
>                                                       '()
>                                                       %default-profile-hooks)
>                                           #:locales? (not bootstrap?))))
> -- 
> 2.13.3
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [PATCH 0/5] Optimize profile hooks
>
>
>
>
> Date: 
>
> Wed, 12 May 2021 19:12:01 +0800
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
>
>
>
>
> Leo Prikler <leo.prikler@student.tugraz.at> writes:
>
> > merge 29928 29926
> > merge 29928 29927
> > thanks
> >
> > This series (29928 29926 29927 29925 29929 29930) has by now slept on
> > the mailing list for more than three years.
> > Should we still try to merge it?  If so, could you send an updated
> > version, that is not spread across six threads?
>
> Hello, thoes patches are obsoleted, should be rewrite to use
> `with-build-handler` (I haven't figure it out how yet).
>
> Look like they were all merged as #29925, I think we can close it for
> now, thank you!
>
>
> --- End Message ---