bug#48114: closed (Disarchive occasionally fails tests)

[GNU bug Tracking System]

Your message dated Thu, 13 May 2021 23:06:07 -0400
with message-id <87sg2qko9s.fsf@ngyro.com>
and subject line Re: bug#48114: Disarchive occasionally fails tests
has caused the debbugs.gnu.org bug report #48114,
regarding Disarchive occasionally fails tests
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
48114: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=48114
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> Disarchive occasionally fails tests
>
>
>
>
> Date: 
>
> Fri, 30 Apr 2021 12:00:36 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
>
>
>
>
> Hi Timothy,
>
> Disarchive 0.2.0 occasionally fails two tests:
>
>   FAIL: tests/kinds/octal.scm - [prop] Writing is reversible
>   FAIL: tests/kinds/octal.scm - [prop] Serializing is reversible
>
> (Thanks, Quickcheck! :-))
>
> I added ‘pk’ calls like so:
>
> --8<---------------cut here---------------start------------->8---
> (test-assert "[prop] Writing is reversible"
>   (quickcheck
>    (property ((octal $octal))
>      (test-when (valid-octal? octal)
>        (begin
>          (equal? (pk 'oct octal) (pk 'decode (decode-octal (encode-octal 
> octal)))))))))
>
> (test-assert "[prop] Serializing is reversible"
>   (quickcheck
>    (property ((octal $octal))
>      (test-when (valid-octal? octal)
>        (equal? (pk 'OCT octal) (pk 'DECODE (serdeser -octal- octal)))))))
> --8<---------------cut here---------------end--------------->8---
>
> and got this output:
>
> --8<---------------cut here---------------start------------->8---
> ;;; (oct #<<unstructured-octal> value: 0 source: #<<zero-string> value: 
> "\U0f94a4\u0912\U025627\U10e96a\u9576\u2077\u048f\U0f2f60\U0f744b" trailer: 
> #vu8(172 156 23 48 25 29 159 226 210)>>)
>
> ;;; (decode #<<unstructured-octal> value: 0 source: #<<zero-string> value: 
> "\U0f94a4\u0912\U025627\U10e96a\u9576\u2077\u048f\U0f2f60\U0f744b" trailer: 
> #vu8(172 156 23 48 25 29 159 226 210)>>)
> actual-value: #f
> actual-error:
> + (out-of-range
> +   #f
> +   "Value out of range ~S to ~S: ~S"
> +   (8 9 10)
> +   (10))
> result: FAIL
>
> […]
>
> ;;; (OCT #<<unstructured-octal> value: 0 source: #<<zero-string> value: 
> "\U0f94a4\u0912\U025627\U10e96a\u9576\u2077\u048f\U0f2f60\U0f744b" trailer: 
> #vu8(172 156 23 48 25 29 159 226 210)>>)
>
> ;;; (DECODE #<<unstructured-octal> value: 0 source: #<<zero-string> value: 
> "\U0f94a4\u0912\U025627\U10e96a\u9576\u2077\u048f\U0f2f60\U0f744b" trailer: 
> #vu8(172 156 23 48 25 29 159 226 210)>>)
> actual-value: #f
> actual-error:
> + (out-of-range
> +   #f
> +   "Value out of range ~S to ~S: ~S"
> +   (8 9 10)
> +   (10))
> result: FAIL
> --8<---------------cut here---------------end--------------->8---
>
> I’m not sure where the exception comes from though.
>
> Thoughts?
>
> Thanks,
> Ludo’.
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#48114: Disarchive occasionally fails tests
>
>
>
>
> Date: 
>
> Thu, 13 May 2021 23:06:07 -0400
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
>
>
>
>
> Heyo,
>
> Ludovic Courtès <ludo@gnu.org> writes:
>
> > Timothy Sample <samplet@ngyro.com> skribis:
> >
> >> In Disarchive, I can rewrite the generator without regex.  I’ll do that
> >> and see what I can do about the “Gave up!” issue.
> >
> > Did you have a chance to look into it?
>
> I just pushed b9f0e78238e6186d28d738c7c5355a56557ce84f, which updates
> Disarchive to 0.2.1, which has fixes for the test suite.  The giving up
> problem has not been solved outright, but it should be practically
> impossible to trigger.  (In fact, it probably *is* impossible to trigger
> given how few PRNG states there are....)
>
> > I’d like to make ‘guix’ and ‘guix-daemon’ depend on Disarchive, but not
> > before we can be sure its test suite passes.
>
> Exciting!
>
>
> -- Tim
>
>
> --- End Message ---