bug#48375: closed (coding-system-for-read in net-utils-run-simple is not properly set)

[GNU bug Tracking System]

Your message dated Sat, 15 May 2021 12:39:25 +0300
with message-id <835yzkxrn6.fsf@gnu.org>
and subject line Re: bug#48375: coding-system-for-read in net-utils-run-simple 
is not properly set
has caused the debbugs.gnu.org bug report #48375,
regarding coding-system-for-read in net-utils-run-simple is not properly set
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
48375: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=48375
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> coding-system-for-read in net-utils-run-simple is not properly set
>
>
>
>
> Date: 
>
> Wed, 12 May 2021 18:39:25 +0900
>
>
>
>
> In the following code, `let' binding of `coding-system-for-read'
> covers only `erase-buffer' call.
>
> https://emba.gnu.org/emacs/emacs/-/blob/47070ed39eda524d334e5f82dc7f4a50b8d3252c/lisp/net/net-utils.el#L366-375
>
> So it does not affect to executed process and output characters are garbled.
> e.g. "M-x ifconfig" on Windows.
>
> `net-utils-run-program' (e.g. "M-x ping") has no problem.
>
> Thanks in advance,
> Iku
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#48375: coding-system-for-read in net-utils-run-simple is not properly set
>
>
>
>
> Date: 
>
> Sat, 15 May 2021 12:39:25 +0300
>
>
>
>
> > From: iquiw <iku.iwasa@gmail.com>
> > Date: Sat, 15 May 2021 18:32:05 +0900
> > Cc: 48375@debbugs.gnu.org
> > 
> > > > In the following code, `let' binding of `coding-system-for-read'
> > > > covers only `erase-buffer' call.
> > > >
> > > > https://emba.gnu.org/emacs/emacs/-/blob/47070ed39eda524d334e5f82dc7f4a50b8d3252c/lisp/net/net-utils.el#L366-375
> > > >
> > > > So it does not affect to executed process and output characters are 
> > > > garbled.
> > > > e.g. "M-x ifconfig" on Windows.
> > >
> > > Thanks.  Does the patch below fix the problem?
> > 
> > Yes, it works fine with the patch.
> > Thank you!
>
> Thanks for testing, I installed the fix on the master branch, and I'm
> closing this bug report.
>
>
> --- End Message ---