bug#48502: closed ([PATCH 0/1] gnu: luakit: Update to 2.3.)

[GNU bug Tracking System]

Your message dated Sat, 22 May 2021 23:37:06 +0200
with message-id <874keu78n1.fsf_-_@gnu.org>
and subject line Re: bug#48502: [PATCH 0/1] gnu: luakit: Update to 2.3.
has caused the debbugs.gnu.org bug report #48502,
regarding [PATCH 0/1] gnu: luakit: Update to 2.3.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
48502: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=48502
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/1] gnu: luakit: Update to 2.3.
>
>
>
>
> Date: 
>
> Tue, 18 May 2021 18:47:10 +0200
>
>
>
>
> Hello,
>
> While updating luakit to 2.3 I noticed the version wasn't detected properly at
> built-time (it's supposed to either use git-describe or a version embedded in
> the release tarball).
>
> Since we build from the git repository, I added a phase to set the version to
> manually.
>
> Raphaël Mélotte (1):
>   gnu: luakit: Update to 2.3.
>
>  gnu/packages/web-browsers.scm | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
>
> -- 
> 2.31.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#48502: [PATCH 0/1] gnu: luakit: Update to 2.3.
>
>
>
>
> Date: 
>
> Sat, 22 May 2021 23:37:06 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
>
>
>
>
> Hi,
>
> Raphaël Mélotte <raphael.melotte@mind.be> skribis:
>
> > * gnu/packages/web-browsers.scm (luakit): Update to 2.3
> > [arguments]: Add 'set-version' phase.
>
> [...]
>
> > +         (add-before 'build 'set-version
> > +           (lambda _
> > +             (setenv "VERSION_FROM_GIT" ,(package-version luakit))
>
> I changed this to (package-version this-package), which works also when
> inheriting from the package, and applied.
>
> Thanks!
>
> Ludo’.
>
>
> --- End Message ---