bug#48368: closed (eq? problem at -O2 since Guile 3.0.5)

[GNU bug Tracking System]

Your message dated Mon, 24 May 2021 14:19:22 +0200
with message-id <87cztg1fzp.fsf@igalia.com>
and subject line thanks
has caused the debbugs.gnu.org bug report #48368,
regarding eq? problem at -O2 since Guile 3.0.5
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
48368: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=48368
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: eq? problem at -O2 since Guile 3.0.5 Date: Tue, 11 May 2021 22:49:19 +0200

Hi!

I haven't been able to make a reproducer for this, but for illustrative
purposes, here is a code snippet that fails with -O2 on Guile 3.0.5 and
later (excerpt from GNU Shepherd):

  (define (run-command socket-file action service args)
    "Perform ACTION with ARGS on SERVICE, and display the result.  Connect to
  the daemon via SOCKET-FILE."
    (with-system-error-handling
     (let ((sock    (open-connection socket-file))
           (action* (if (and (eq? action 'detailed-status)
                             (memq service '(root shepherd)))
                        'status
                        action)))
       ;; Send the command.
       (write-command (shepherd-command action* service #:arguments args)
                      sock)

https://git.savannah.gnu.org/cgit/shepherd.git/tree/modules/shepherd/scripts/herd.scm#n124

At -O2, (eq? action 'detailed-status) evaluates to true no matter what
symbol ACTION holds.

Interestingly, adding (pk action*) between LET and WRITE-COMMAND gives
the expected result and mitigates the problem(!).

There are other issues that can be observed by running the Shepherd test
suite (i.e. make -j4 check).  With -O1 all pass.

signature.asc
Description: PGP signature

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> thanks
>
>
>
>
> Date: 
>
> Mon, 24 May 2021 14:19:22 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
>
>
>
>
> Fixed in 17aab66e75136cf23c7f0d4942b61d6947f98f9b.  Thanks for the
> report :)
>
>
> --- End Message ---