bug#49740: closed ([PATCH] [core-updates?] gnu: r-with-tests: Hardcode path to coreutils’ rm)

[GNU bug Tracking System]

Your message dated Mon, 26 Jul 2021 13:15:32 +0200
with message-id <YP6ZVFGMy4jtGudV@noor.fritz.box>
and subject line Re: [bug#49740] [PATCH] [core-updates?] gnu: r-with-tests: 
Hardcode path to coreutils’ rm
has caused the debbugs.gnu.org bug report #49740,
regarding [PATCH] [core-updates?] gnu: r-with-tests: Hardcode path to 
coreutils’ rm
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
49740: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=49740
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] [core-updates?] gnu: r-with-tests: Hardcode path to coreutils’ rm
>
>
>
>
> Date: 
>
> Mon, 26 Jul 2021 09:25:19 +0200
>
>
>
>
> When running R in a container like this
>
>         guix environment --no-cwd -C --ad-hoc r-minimal -- Rscript -e 
> 'Sys.timezone()'
>
> it would print an additional line
>
>         sh: rm: command not found
>
> before exiting.
>
> * gnu/packages/statistics.scm (r-with-tests) [#:phases]: Add substitute*
> to patch call to `rm` and rename phase to reflect what it does now.
> ---
>  gnu/packages/statistics.scm | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
> index ce9f1bf888..7ba7d9f20d 100644
> --- a/gnu/packages/statistics.scm
> +++ b/gnu/packages/statistics.scm
> @@ -213,12 +213,15 @@ This package also provides @command{xls2csv} to export 
> Excel files to CSV.")
>               (substitute* "src/library/base/makebasedb.R"
>                 (("compress = TRUE") "compress = FALSE"))
>               #t))
> -         (add-before 'configure 'patch-uname
> +         (add-before 'configure 'patch-coreutils-paths
>             (lambda* (#:key inputs #:allow-other-keys)
> -             (let ((uname-bin (string-append (assoc-ref inputs "coreutils")
> -                                             "/bin/uname")))
> +             (let* ((coreutils (assoc-ref inputs "coreutils"))
> +                   (uname-bin (string-append coreutils "/bin/uname"))
> +                   (rm-bin (string-append coreutils "/bin/rm")))
>                 (substitute* "src/scripts/R.sh.in"
> -                 (("uname") uname-bin)))
> +                 (("uname") uname-bin))
> +               (substitute* "src/unix/sys-std.c"
> +                 (("rm -Rf ") (string-append rm-bin " -Rf "))))
>               #t))
>           (add-after 'unpack 'build-reproducibly
>             (lambda _
> -- 
> 2.31.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#49740] [PATCH] [core-updates?] gnu: r-with-tests: Hardcode path to coreutils’ rm
>
>
>
>
> Date: 
>
> Mon, 26 Jul 2021 13:15:32 +0200
>
>
>
>
> Hi,
>
> done, closing.
>
> Lars
>
>
>
> --- End Message ---