bug#50341: closed ([PATCH 0/1] emacs-org-roam include extensions)

[GNU bug Tracking System]

Your message dated Fri, 03 Sep 2021 10:25:43 -0400
with message-id <877dfxag3g.fsf@rekahsoft.ca>
and subject line Re: [PATCH 1/1] gnu: Update emacs-org-roam to include 
extensions
has caused the debbugs.gnu.org bug report #50341,
regarding [PATCH 0/1] emacs-org-roam include extensions
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
50341: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=50341
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/1] emacs-org-roam include extensions
>
>
>
>
> Date: 
>
> Thu, 02 Sep 2021 12:27:15 -0400
>
>
>
>
> User-agent: 
>
> mu4e 1.6.5; emacs 27.2
>
>
>
>
> This resolves issues with the emacs-org-roam packages after the 2.0.0 ->
> 2.1.0 upgrade. Upstream, some parts of org-roam have been moved to an
> extensions directory. This patch also includes these extensions.
>
> In the future, we may want to provide these as a separate output.
>
> Collin J. Doering (1):
>   gnu: Update emacs-org-roam to include extensions
>
>  gnu/packages/emacs-xyz.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> -- 
> 2.33.0
>
> -- 
> Collin J. Doering
>
> http://rekahsoft.ca
> http://blog.rekahsoft.ca
> http://git.rekahsoft.ca
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [PATCH 1/1] gnu: Update emacs-org-roam to include extensions
>
>
>
>
> Date: 
>
> Fri, 03 Sep 2021 10:25:43 -0400
>
>
>
>
> User-agent: 
>
> mu4e 1.6.5; emacs 27.2
>
>
>
>
> I realized this morning that this change, unlike
> https://issues.guix.gnu.org/50333 does not copy extensions into the
> load-path that will be used, which is certainly not favorable.
>
> I think that longer term we likely want to have a separate package that
> includes these org-roam extensions.
>
> Closing this issue in preference of 50333.
>
> On 02 Sep 2021 at 12:48, "Collin J. Doering" <collin@rekahsoft.ca> wrote:
>
> > Noticed that this duplicates (https://issues.guix.gnu.org/50333),
> > however in 50333, another build phase is added to copy over extensions
> > which is not necessary give the #:include option (as used in the patchset).
> >
> > On 02 Sep 2021 at 12:36, "Collin J. Doering" <collin@rekahsoft.ca> wrote:
> >
> >> ---
> >>  gnu/packages/emacs-xyz.scm | 3 ++-
> >>  1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> >> index c106e81fa5..bb6d0b0757 100644
> >> --- a/gnu/packages/emacs-xyz.scm
> >> +++ b/gnu/packages/emacs-xyz.scm
> >> @@ -28232,7 +28232,8 @@ snippets for Emacs.")
> >>          (base32 "092xn0sqc7b7f6pdf7m6c3giqqbh6fq02mfz8qrg0wmx4ds1isqp"))))
> >>      (build-system emacs-build-system)
> >>      (arguments
> >> -     `(#:phases
> >> +     `(#:include (cons "^extensions/" %default-include)
> >> +       #:phases
> >>         (modify-phases %standard-phases
> >>           (add-after 'install 'install-image
> >>             (lambda* (#:key outputs #:allow-other-keys)
> >> -- 
> >> 2.33.0
>
>
> -- 
> Collin J. Doering
>
> http://rekahsoft.ca
> http://blog.rekahsoft.ca
> http://git.rekahsoft.ca
>
>
> --- End Message ---