bug#47172: closed (Shepherd 0.8.1 tests fail on core-updates)

[GNU bug Tracking System]

Your message dated Thu, 30 Sep 2021 10:57:49 +0200
with message-id <87k0iy4f02.fsf@gnu.org>
and subject line Re: bug#47172: Shepherd 0.8.1 tests fail on core-updates
has caused the debbugs.gnu.org bug report #47172,
regarding Shepherd 0.8.1 tests fail on core-updates
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
47172: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=47172
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: GNU Shepherd 0.8.1 fails on core-updates Date: Mon, 15 Mar 2021 19:51:24 +0100 User-agent: Evolution 3.34.2

Some tests fail:

FAIL: tests/no-home.sh
FAIL: tests/status-sexp.sh
PASS: tests/misbehaved-client.sh
FAIL: tests/replacement.sh
PASS: tests/file-creation-mask.sh
PASS: tests/restart.sh
PASS: tests/one-shot.sh
FAIL: tests/basic.sh
PASS: tests/respawn-throttling.sh
PASS: tests/signals.sh
PASS: tests/respawn.sh
PASS: tests/forking-service.sh
PASS: tests/pid-file.sh

Attached bzip2 compressed full log

3qhfxagkqrx96xci8ylc4lj3s4zvd2-shepherd-0.8.1.drv.bz2
Description: application/bzip

signature.asc
Description: This is a digitally signed message part

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#47172: Shepherd 0.8.1 tests fail on core-updates
>
>
>
>
> Date: 
>
> Thu, 30 Sep 2021 10:57:49 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
>
>
>
>
> Hi,
>
> Marius Bakke <marius@gnu.org> skribis:
>
> > Ludovic Courtès <ludo@gnu.org> skriver:
>
> [...]
>
> >> A workaround that works with 3.0.7 is swapping the two ‘and’
> >> sub-expressions:
> >>
> >> diff --git a/modules/shepherd/scripts/herd.scm 
> >> b/modules/shepherd/scripts/herd.scm
> >> index 106de1e..39d2e34 100644
> >> --- a/modules/shepherd/scripts/herd.scm
> >> +++ b/modules/shepherd/scripts/herd.scm
> >> @@ -126,8 +126,8 @@ of pairs."
> >>  the daemon via SOCKET-FILE."
> >>    (with-system-error-handling
> >>     (let ((sock    (open-connection socket-file))
> >> -         (action* (if (and (eq? action 'detailed-status)
> >> -                           (memq service '(root shepherd)))
> >> +         (action* (if (and (memq service '(root shepherd))
> >> +                           (eq? action 'detailed-status))
> >>                        'status
> >>                        action)))
> >>       ;; Send the command.
> >
> > Cc'ing the relevant Guile bug:
> >
> >   https://bugs.gnu.org/48368
> >
> > See also commit 79be6a985799adc6d663890250f4fb7c12f015b4 on
> > 'core-updates' that builds with -O1 as a less satisfactory workaround.
>
> The bug has been fixed in Guile (will be in 3.0.8), worked around in
> Shepherd commit a066c5ac05037a6ffad8e4ea3e8de8150869aa8b, and worked
> around in Guix on ‘core-updates’, so I think we can close it now.
>
> Thanks,
> Ludo’.
>
>
> --- End Message ---