bug#40429: closed ([PATCH] gnu: Add emacs-flymake-shellcheck.)

[GNU bug Tracking System]

Your message dated Thu, 4 Nov 2021 15:05:19 +0200
with message-id <YYPajyv/00+5HQgP@3900XT>
and subject line Re: [PATCH v2] gnu: emacs-flymake-shellcheck: Add shellcheck 
as an input
has caused the debbugs.gnu.org bug report #51364,
regarding [PATCH] gnu: Add emacs-flymake-shellcheck.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
51364: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=51364
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] gnu: Add emacs-flymake-shellcheck. Date: Sat, 04 Apr 2020 10:35:13 -0500

Patch file is attached.

--
Joseph LaFreniere

0001-gnu-Add-emacs-flymake-shellcheck.patch
Description: Text Data

--- End Message ---

--- Begin Message --- Subject: Re: [PATCH v2] gnu: emacs-flymake-shellcheck: Add shellcheck as an input Date: Thu, 4 Nov 2021 15:05:19 +0200

On Tue, Nov 02, 2021 at 07:13:10PM -0400, Morgan.J.Smith@outlook.com wrote:
> From: Morgan Smith <Morgan.J.Smith@outlook.com>
> 
> * gnu/packages/emacs-xyz.scm (emacs-flymake-shellcheck)
> [inputs]: Add shellcheck.
> [arguments]: Add substitute-shellcheck-path phase.
> ---
> 
> Sorry for the late reply, I didn't see this in my email.
> 
> People would still have been able to set the variable from their 
> configuration.  The value I'm editing just determines the default value.  
> However, I think I came up with a nice solution that should make everyone 
> happy.  It first checks if there is shellcheck in your path and only hard 
> codes the path if you don't have it.  Apparently Emacs even re-evaluates 
> defcustoms in certain situations so this *might* even work if someone 
> installs shellcheck after this file has been loaded.

Looks good to me. Patch pushed.

You also might've missed the email because my self-hosted email server
sometimes gets blocked. I've added you to X-Debbugs-CC so you should get
this email directly.

-- 
Efraim Flashner   <efraim@flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

signature.asc
Description: PGP signature

--- End Message ---