bug#51793: closed (FAIL: tests/misc/env-signal-handler)

[GNU bug Tracking System]

Your message dated Sat, 13 Nov 2021 12:18:39 +0000
with message-id <30c0d4ce-2e63-8389-b4ac-091d888945cd@draigBrady.com>
and subject line Re: bug#51793: FAIL: tests/misc/env-signal-handler
has caused the debbugs.gnu.org bug report #51793,
regarding FAIL: tests/misc/env-signal-handler
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
51793: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=51793
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> FAIL: tests/misc/env-signal-handler
>
>
>
>
> Date: 
>
> Fri, 12 Nov 2021 20:25:39 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
>
>
>
>
> --- exp-err6   2021-11-11 22:58:04.360716802 +0000
> +++ err6       2021-11-11 22:58:04.752716821 +0000
> @@ -1,2 +1 @@
>  timeout: sending signal INT to command 'env'
> -timeout: sending signal KILL to command 'env'
> ./tests/misc/env-signal-handler.sh: line 127: 26396 Killed                  env 
> timeout --verbose --kill-after=.1 --signal=INT .1 env --ignore-signal sleep 10 
> > /dev/null 2> err7t
> FAIL tests/misc/env-signal-handler.sh (exit status: 1)
>
> Andreas.
>
> -- 
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
> "And now for something completely different."
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: bug#51793: FAIL: tests/misc/env-signal-handler Date: Sat, 13 Nov 2021 12:18:39 +0000 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:95.0) Gecko/20100101 Thunderbird/95.0

On 13/11/2021 09:46, Andreas Schwab wrote:

On Nov 12 2021, Pádraig Brady wrote:

I've never seen this, and I can't see the race.

There is an obvious race: if env needs more than .1 seconds to set the
SIGINT handler.

Indeed.

That fits the pattern where we need a certain delay to pass.
So we can use our retry_delay_ helper here.
I'll apply the attached later.

thanks,
Pádraig

test-env-race.patch
Description: Text Data

--- End Message ---