bug#51091: closed ([PATCH] guix: opam: Do not fail when refreshing.)

[GNU bug Tracking System]

Your message dated Fri, 19 Nov 2021 14:49:02 -0500
with message-id <C9F1C28B-4DAA-47A0-B183-FB754C8CDDC6@lepiller.eu>
and subject line Re: [bug#51091] [PATCH v3] guix: opam: Do not fail when 
refreshing.
has caused the debbugs.gnu.org bug report #51091,
regarding [PATCH] guix: opam: Do not fail when refreshing.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
51091: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=51091
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] guix: opam: Do not fail when refreshing. Date: Fri, 8 Oct 2021 05:03:10 +0200

Hi Guix!

the attached patch prevents early failures in "guix refresh -t opam".
It will now simply continue when it encounters a package that is not in
the opam repository.

0001-guix-opam-Do-not-fail-when-refreshing.patch
Description: Text Data

--- End Message ---

--- Begin Message --- Subject: Re: [bug#51091] [PATCH v3] guix: opam: Do not fail when refreshing. Date: Fri, 19 Nov 2021 14:49:02 -0500 User-agent: K-9 Mail for Android Forgot to send to the address that actually closes the issue ^^"

---

De : Julien Lepiller <julien@lepiller.eu>
Envoyé : 19 novembre 2021 13:13:08 GMT-05:00
À : zimoun <zimon.toutoune@gmail.com>
Cc : "Ludovic Courtès" <ludo@gnu.org>, Xinglu Chen <public@yoctocell.xyz>
Objet : Re: [bug#51091] [PATCH v3] guix: opam: Do not fail when refreshing.

So, since I pushed Zimoun's patch, I'm closing this one. I received some help on IRC this morning so I should be able to come up with something more generic for all importers at some point. Zimoun if you want to work on that, I'd be happy to collaborate :)

Le 19 novembre 2021 06:30:20 GMT-05:00, zimoun <zimon.toutoune@gmail.com> a écrit :

Hi Julien,

On Fri, 19 Nov 2021 at 12:21, Julien Lepiller <julien@lepiller.eu> wrote:

I forgot to remove the catch #t around the whole body of the function.
I noticed that guard* was raising &non-continuable so I tried to fix it
by using raise-continuable from (ice-9 exceptions). Is this the correct
solution?

I suppose, though I’m not sure why it needs to be continuable: you could
just catch the exception and move on to the next package?

 I don't understand how to catch the exception though, unless you mean wrap everything with catch #t, which kinda defeats the purpose of having a condition in the first pjace. guard* raises &non-continuable unless the condition is continuable, or I'm missing something in the way I use it. I have no idea what a continuable exception is, so let me just push the other patch.

 (guard* (c ((opam-error? c) #f)))
   (raise (condition (&opam-error …))))

 Doesn't return #f as I expect, but raises &non-continuable.

I sympathize and I had / is still having hard time with similar use
cases.  That's one of the reasons (among my laziness :-)) that [1] is
not fixed yet. :-)

1: <1: <http://issues.guix.gnu.org/issue/45984>



Hopefully someone smarter than me can figure it out. I'll push the other patch, although I don't like the double warning in the updater.

I agree.  And move all G_ strings to guix/scripts/ is a good idea, IMHO.
Well, I do not know. :-)

(I secretly hoped that you would be the smarter than me person fixing
the recursive importers. ;-))


Cheers,
simon

--- End Message ---