bug#53660: closed ([PATCH] services/sound: Add a udev extension for the pulseaudio service type.)

[GNU bug Tracking System]

Your message dated Tue, 01 Feb 2022 21:54:11 -0500
with message-id <87sft2yo4s.fsf@gmail.com>
and subject line Re: [PATCH] services/sound: Add a udev extension for the 
pulseaudio service type.
has caused the debbugs.gnu.org bug report #53660,
regarding [PATCH] services/sound: Add a udev extension for the pulseaudio 
service type.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
53660: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=53660
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] services/sound: Add a udev extension for the pulseaudio service type.
>
>
>
>
> Date: 
>
> Mon, 31 Jan 2022 09:54:07 -0500
>
>
>
>
> PulseAudio provides udev rules used to adjust the configuration of certain
> hardware (e.g., sound cards); ensure they get used.
>
> * gnu/services/sound.scm (pulseaudio-service-type): Extend the
> udev-service-type with the pulseaudio package.
> ---
>  gnu/services/sound.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/services/sound.scm b/gnu/services/sound.scm
> index 1217223a0c..7beca35ffe 100644
> --- a/gnu/services/sound.scm
> +++ b/gnu/services/sound.scm
> @@ -159,7 +159,9 @@ (define pulseaudio-service-type
>     (extensions
>      (list (service-extension session-environment-service-type
>                               pulseaudio-environment)
> -          (service-extension etc-service-type pulseaudio-etc)))
> +          (service-extension etc-service-type pulseaudio-etc)
> +          (service-extension udev-service-type (lambda _
> +                                                 (list pulseaudio)))))
>     (default-value (pulseaudio-configuration))
>     (description "Configure PulseAudio sound support.")))
>  
> -- 
> 2.34.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [PATCH] services/sound: Add a udev extension for the pulseaudio service type.
>
>
>
>
> Date: 
>
> Tue, 01 Feb 2022 21:54:11 -0500
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
>
>
>
>
> Hello,
>
> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
>
> > Am Montag, dem 31.01.2022 um 09:54 -0500 schrieb Maxim Cournoyer:
> >> PulseAudio provides udev rules used to adjust the configuration of
> >> certain
> >> hardware (e.g., sound cards); ensure they get used.
> >> 
> >> * gnu/services/sound.scm (pulseaudio-service-type): Extend the
> >> udev-service-type with the pulseaudio package.
> >> ---
> >>  gnu/services/sound.scm | 4 +++-
> >>  1 file changed, 3 insertions(+), 1 deletion(-)
> >> 
> >> diff --git a/gnu/services/sound.scm b/gnu/services/sound.scm
> >> index 1217223a0c..7beca35ffe 100644
> >> --- a/gnu/services/sound.scm
> >> +++ b/gnu/services/sound.scm
> >> @@ -159,7 +159,9 @@ (define pulseaudio-service-type
> >>     (extensions
> >>      (list (service-extension session-environment-service-type
> >>                               pulseaudio-environment)
> >> -          (service-extension etc-service-type pulseaudio-etc)))
> >> +          (service-extension etc-service-type pulseaudio-etc)
> >> +          (service-extension udev-service-type (lambda _
> >> +                                                 (list
> >> pulseaudio)))))
> > You should use const, otherwise SGTM.
>
> Good catch!  Adjusted and pushed as
> fff4daa5c2bfbf42c7ad2519f500bd254ce880a8.
>
> Thank you,
>
> Maxim
>
>
> --- End Message ---