bug#54001: closed (29.0.50; abbreviate-file-name has side-effects)

[GNU bug Tracking System]

Your message dated Tue, 15 Feb 2022 08:11:35 -0500
with message-id <jwvee44ff7c.fsf-monnier+emacs@gnu.org>
and subject line Re: bug#54001: 29.0.50; abbreviate-file-name has side-effects
has caused the debbugs.gnu.org bug report #54001,
regarding 29.0.50; abbreviate-file-name has side-effects
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
54001: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=54001
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 29.0.50; abbreviate-file-name has side-effects
>
>
>
>
> Date: 
>
> Mon, 14 Feb 2022 12:19:57 -0500
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
>
>
>
>
> Package: Emacs
> Version: 29.0.50
>
>
> Since:
>
>     commit bf505a63f98ed61934a8fb81ec65c96859606b6e
>     Author: Jim Porter <jporterbugs@gmail.com>
>     Date:   Mon Nov 15 13:33:07 2021 +0100
>
>     Support abbreviating home directory of Tramp filenames
>
> `abbreviate-file-name` has significantly changed in its behavior:
> - it's slower (because it goes through file-name-handlers)
> - it can have very visible side effects like prompting the user for a password.
>
> I haven't measured the slowdown, so I'll assume it's acceptable, but
> asking for a password (or contacting a remote host) is not.
>
> I suggest we take a step back and think of how to get that feature
> without having to contact any remote host during `abbreviate-file-name`.
> Maybe we can do that by making Tramp opportunistically add entries to
> `directory-abbrev-alist` when it performs expansion?
>
>
>         Stefan
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#54001: 29.0.50; abbreviate-file-name has side-effects
>
>
>
>
> Date: 
>
> Tue, 15 Feb 2022 08:11:35 -0500
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
>
>
>
>
> > I've only lightly tested this patch, but I think it should resolve the
> > issue. It only sets the "home-directory" connection property when
> > a connection is already established. Otherwise, it just uses the cached
> > value (if any).
>
> Thanks, pushed to master.  And closing.
> Daniel, feel to ping us back if the fix isn't good enough.
>
>
>         Stefan
>
>
>
> --- End Message ---