bug#53872: closed ([PATCH] gnu: maven: Use required logger)

[GNU bug Tracking System]

Your message dated Mon, 28 Feb 2022 11:00:00 +0100
with message-id <20220228110000.1872f52e@tachikoma.lepiller.eu>
and subject line Re: bug#53872: [PATCH] gnu: maven: Use required logger
has caused the debbugs.gnu.org bug report #53872,
regarding [PATCH] gnu: maven: Use required logger
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
53872: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=53872
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] gnu: maven: Use required logger Date: Tue, 8 Feb 2022 10:42:31 +0100

Hi Guix!

I figured there was a small issue with our maven package. It warns that
the current logger is not supported, and lists no supported logger.
This is because I forgot to copy resources in maven-embedder (first
patch). I also noticed I missed resources in maven-compat, so I fixed
that in the second patch.

Then, maven uses its own logger instead of a default one, even if it
does support slf4j-simple. The third patch adds maven-slf4j-wrapper. It
is essentially a fork of slf4j-simple, but the way it's written
requires me to copy most of slf4j-simple's sources. The last patch
switches the use of slf4j-simple to maven-slf4j-provider. I checked
that java-jmh still builds properly with this change, and no warnings
are shown about the logger anymore.

0001-gnu-maven-embedder-Install-resources.patch
Description: Text Data

0002-gnu-maven-compat-Install-resources.patch
Description: Text Data

0003-gnu-Add-maven-slf4j-provider.patch
Description: Text Data

0004-gnu-maven-Use-maven-slf4j-provider-instead-of-slf4j-.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#53872: [PATCH] gnu: maven: Use required logger
>
>
>
>
> Date: 
>
> Mon, 28 Feb 2022 11:00:00 +0100
>
>
>
>
> With no other answer after more than two weeks since I posted the patch
> series, pushed to master as ea23386e084a035e4bc23273fffc3d114b311789 -
> 9aae8a3e0d53fd0c11b8e98e1fd2d2232598b036. Thanks!
>
> Le Wed, 16 Feb 2022 16:03:23 +0100,
> Ludovic Courtès <ludo@gnu.org> a écrit :
>
> > Hi,
> > 
> > Julien Lepiller <julien@lepiller.eu> skribis:
> > 
> > > I figured there was a small issue with our maven package. It warns
> > > that the current logger is not supported, and lists no supported
> > > logger. This is because I forgot to copy resources in
> > > maven-embedder (first patch). I also noticed I missed resources in
> > > maven-compat, so I fixed that in the second patch.
> > >
> > > Then, maven uses its own logger instead of a default one, even if it
> > > does support slf4j-simple. The third patch adds
> > > maven-slf4j-wrapper. It is essentially a fork of slf4j-simple, but
> > > the way it's written requires me to copy most of slf4j-simple's
> > > sources. The last patch switches the use of slf4j-simple to
> > > maven-slf4j-provider. I checked that java-jmh still builds properly
> > > with this change, and no warnings are shown about the logger
> > > anymore.  
> > 
> > I know nothing about Maven but I’d say you can go ahead if the other
> > Java folks around here have nothing to say.
> > (When do we set up teams? :-))
> > 
> > Thanks,
> > Ludo’.
>
>
>
> --- End Message ---