bug#54410: closed (One cl-defgeneric in xref.el should be cl-defmethod)

[GNU bug Tracking System]

Your message dated Thu, 17 Mar 2022 13:07:52 +0100
with message-id 
<CAArVCkSgmZMCaZP3jZp4pdGveJni6Qn5_E0OajkFSqZPDS=u8Q@mail.gmail.com>
and subject line Re: bug#54410: One cl-defgeneric in xref.el should be 
cl-defmethod
has caused the debbugs.gnu.org bug report #54410,
regarding One cl-defgeneric in xref.el should be cl-defmethod
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
54410: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=54410
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: One cl-defgeneric in xref.el should be cl-defmethod Date: Wed, 16 Mar 2022 00:09:23 +0100

Tags: patch

Is the following patch good for the release branch?



In GNU Emacs 28.0.92 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.31, cairo 
version 1.16.0)
 of 2022-03-14
Repository revision: 8e7a3f21e00649bacc01be627edd45ff01b51a33
Repository branch: emacs-28
Windowing system distributor 'The X.Org Foundation', version 11.0.12014000
System Description: Debian GNU/Linux rodete

Configured using:
 'configure --enable-gcc-warnings=warn-only
 --enable-gtk-deprecation-warnings --without-pop --with-mailutils
 --enable-checking=all --enable-check-lisp-object-type --with-modules
 'CFLAGS=-O0 -ggdb3''

xref-defmethod.patch
Description: Text Data

-- 
Google Germany GmbH
Erika-Mann-Straße 33
80636 München

Geschäftsführer: Paul Manicle, Liana Sebastian
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg

Diese E-Mail ist vertraulich.  Falls Sie diese fälschlicherweise erhalten haben
sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie
alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail
an die falsche Person gesendet wurde.

This e-mail is confidential.  If you received this communication by mistake,
please don’t forward it to anyone else, please erase all copies and
attachments, and please let me know that it has gone to the wrong person.

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#54410: One cl-defgeneric in xref.el should be cl-defmethod
>
>
>
>
> Date: 
>
> Thu, 17 Mar 2022 13:07:52 +0100
>
>
>
>
> Am Mi., 16. März 2022 um 04:29 Uhr schrieb Eli Zaretskii <eliz@gnu.org>:
> >
> > > From: Philipp Stephani <p.stephani2@gmail.com>
> > > Date: Wed, 16 Mar 2022 00:09:23 +0100
> > >
> > > Is the following patch good for the release branch?
> >
> > What problems are caused by the current code?
>
> I'm using Edebug for coverage instrumentation, and that only works
> right in an automated way if there are no duplicate instrumented
> symbols, because Edebug attaches coverage information to individual
> symbols. cl-defmethod takes care of this by generating additional
> symbols, but cl-defgeneric doesn't.
>
> >
> > In general, I'd prefer to leave the release branch alone at this time,
> > so we could release Emacs 28.1 soon.  It seems quite ready.
>
> Fine with me, I've pushed it to master as commit
> 6ed3f04e5a3c8aee40a26805bb00cdd070eba319.
>
>
> --- End Message ---