bug#54565: closed (29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds)

[GNU bug Tracking System]

Your message dated Fri, 13 May 2022 20:51:36 +0800
with message-id <87v8u9tx2f.fsf@yahoo.com>
and subject line Re: bug#54564: 29.0.50; [PATCH] Use gsettings font rendering 
entries for pgtk builds
has caused the debbugs.gnu.org bug report #54564,
regarding 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
54564: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54564
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds Date: Fri, 25 Mar 2022 13:17:41 +0100 User-agent: Evolution 3.40.4-1ubuntu2

Hello, 

When using the pgtk build of emacs under Wayland/Ubuntu, I noticed that

the font hinting was different from the regular X (Ubuntu supplied)

version of emacs.

I have the gsettings config for font hinting set to "full" on my

system, using the fonts tab in the gnome-tweaks tool.

It looks like Cairo defaults to the "slight" hinting setting when using

the Wayland backend for display and will only use the gsettings config

when rendering to an X backend, when it reads the current font settings

from xrdb.

I've attached a patch (against

380f0443b288c68df3762ee20d78719f08dd92ff) which applies the font

entries from gsettings (if present) when creating a font in Cairo.

Note that this patch won't dynamically re-render when emacs is already

running (like it does when changing the system font).

I made an attempt to hook into the gsettings change callback, but could

not force a re-creation of the font with the changed parameters,for

instance using a 'font-render' config changed event. Any pointers on

how to achieve this?

 

Do you think if this patch is a good approach to get the pgtk build to

use the system preferences for font hinting and anti-aliasing?

Kind Regards,

Pieter van Prooijen

    

0001-Use-gsettings-font-rendering-entries-for-pgtk-builds.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#54564: 29.0.50; [PATCH] Use gsettings font rendering entries for pgtk builds
>
>
>
>
> Date: 
>
> Fri, 13 May 2022 20:51:36 +0800
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux)
>
>
>
>
> Pieter van Prooijen <pieter.van.prooijen@teloden.nl> writes:
>
> > Hello All,
> >
> > The copyright assignment paperwork came through, is it possible to
> > incorporate the gsetting font rendering changes? I've attached a patch
> > against the current master, let me know if I need to change anything.
>
> Thank you.  I will install this shortly and am closing this bug.
>
>
> --- End Message ---