bug#53039: closed ([PATCH] build-system/python: Change let* to let.)

[GNU bug Tracking System]

Your message dated Wed, 18 May 2022 09:06:58 -0400
with message-id <87czgb0z2l.fsf@gmail.com>
and subject line Re: bug#53039: [PATCH] build-system/python: Change let* to let.
has caused the debbugs.gnu.org bug report #53039,
regarding [PATCH] build-system/python: Change let* to let.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
53039: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=53039
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] build-system/python: Change let* to let.
>
>
>
>
> Date: 
>
> Wed,  5 Jan 2022 17:46:00 -0500
>
>
>
>
> * guix/build/python-build-system.scm (site-packages): Change let* to let for
> readability and since let* is unused.
> ---
>  guix/build/python-build-system.scm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/guix/build/python-build-system.scm 
> b/guix/build/python-build-system.scm
> index 08871f60cd..a9b1c74f63 100644
> --- a/guix/build/python-build-system.scm
> +++ b/guix/build/python-build-system.scm
> @@ -11,6 +11,7 @@
>  ;;; Copyright © 2020 Efraim Flashner <efraim@flashner.co.il>
>  ;;; Copyright © 2021 Lars-Dominik Braun <lars@6xq.net>
>  ;;; Copyright © 2021 Maxime Devos <maximedevos@telenet.be>
> +;;; Copyright © 2022 jgart <jgart@dismail.de>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -176,8 +177,8 @@ (define (python-output outputs)
>  
>  (define (site-packages inputs outputs)
>    "Return the path of the current output's Python site-package."
> -  (let* ((out (python-output outputs))
> -         (python (assoc-ref inputs "python")))
> +  (let ((out (python-output outputs))
> +        (python (assoc-ref inputs "python")))
>      (string-append out "/lib/python" (python-version python) 
> "/site-packages")))
>  
>  (define (add-installed-pythonpath inputs outputs)
> -- 
> 2.34.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#53039: [PATCH] build-system/python: Change let* to let.
>
>
>
>
> Date: 
>
> Wed, 18 May 2022 09:06:58 -0400
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
>
>
>
>
> Hi,
>
> jgart <jgart@dismail.de> writes:
>
> > * guix/build/python-build-system.scm (site-packages): Change let* to let for
> > readability and since let* is unused.
> > ---
> >  guix/build/python-build-system.scm | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/guix/build/python-build-system.scm 
> > b/guix/build/python-build-system.scm
> > index 08871f60cd..a9b1c74f63 100644
> > --- a/guix/build/python-build-system.scm
> > +++ b/guix/build/python-build-system.scm
> > @@ -11,6 +11,7 @@
> >  ;;; Copyright © 2020 Efraim Flashner <efraim@flashner.co.il>
> >  ;;; Copyright © 2021 Lars-Dominik Braun <lars@6xq.net>
> >  ;;; Copyright © 2021 Maxime Devos <maximedevos@telenet.be>
> > +;;; Copyright © 2022 jgart <jgart@dismail.de>
> >  ;;;
> >  ;;; This file is part of GNU Guix.
> >  ;;;
> > @@ -176,8 +177,8 @@ (define (python-output outputs)
> >  
> >  (define (site-packages inputs outputs)
> >    "Return the path of the current output's Python site-package."
> > -  (let* ((out (python-output outputs))
> > -         (python (assoc-ref inputs "python")))
> > +  (let ((out (python-output outputs))
> > +        (python (assoc-ref inputs "python")))
> >      (string-append out "/lib/python" (python-version python) 
> > "/site-packages")))
> >  
> >  (define (add-installed-pythonpath inputs outputs)
>
> As Maxime mentioned, that should go to core-updates.  It's nice to use
> the --subject-prefix option of 'git format-patch' to change it to
> "[PATCH core-updates]", so that we don't apply these mistakenly to
> master and cause world rebuilds :-)
>
> Another note; only changes of minimally 10 lines are copyrightable, so
> you do not need to add a copyright attribution for trivial changes such
> as this one.
>
> I've made the change to core-updates and committed as 47fac5dc59; closing.
>
> Thank you!
>
> Maxim
>
>
> --- End Message ---