bug#55531: closed ([PATCH] gnu: dumb: Fix build.)

[GNU bug Tracking System]

Your message dated Tue, 24 May 2022 16:54:12 +0200
with message-id <87mtf7j817.fsf@gnu.org>
and subject line Re: bug#55531: [PATCH] gnu: dumb: Fix build.
has caused the debbugs.gnu.org bug report #55531,
regarding [PATCH] gnu: dumb: Fix build.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
55531: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55531
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: dumb: Fix build.
>
>
>
>
> Date: 
>
> Fri, 20 May 2022 03:55:11 +0000
>
>
>
>
> * gnu/packages/music.scm (dumb, dumb-allegro4): Fix failing build of "dumb"
>   caused by missing allegro-4 dependency.
> ---
> This patch fixes the failing build of the "dumb" package by removing the
> need to have allegro-4. I am not sure why Guix needs both "dumb" and
> "dumb-allegro4". By default, dumb requires allegro-4.
>
>
>  gnu/packages/music.scm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index 210af3b166..bb456abdb1 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -705,7 +705,8 @@ background while you work.")
>      (arguments
>       '(#:tests? #f ; no check target
>         #:configure-flags
> -       (list "-DBUILD_SHARED_LIBS=ON"
> +       (list "-DBUILD_ALLEGRO4=OFF"
> +             "-DBUILD_SHARED_LIBS=ON"
>               "-DBUILD_EXAMPLES=OFF")))
>      (home-page "https://github.com/kode54/dumb";)
>      (synopsis "Module audio renderer library")
> @@ -729,7 +730,7 @@ settings (aliasing, linear interpolation and cubic 
> interpolation).")
>      (arguments
>       (substitute-keyword-arguments (package-arguments dumb)
>         ((#:configure-flags flags)
> -        `(cons "-DBUILD_ALLEGRO4=ON" ,flags))))
> +        `(cons "-DBUILD_ALLEGRO4=ON" ,(delete "-DBUILD_ALLEGRO4=OFF" flags)))))
>      (inputs
>       (list allegro-4))))
>  
>
> base-commit: cf17cbbc1b16dd15c8ec2e637d240de7ae5c3a44
> -- 
> 2.25.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#55531: [PATCH] gnu: dumb: Fix build.
>
>
>
>
> Date: 
>
> Tue, 24 May 2022 16:54:12 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
>
>
>
>
> Hi,
>
> Foo Chuan Wei <chuanwei.foo@hotmail.com> skribis:
>
> > * gnu/packages/music.scm (dumb, dumb-allegro4): Fix failing build of "dumb"
> >   caused by missing allegro-4 dependency.
>
> Applied, thanks!
>
> Ludo’.
>
> PS: Your MUA wrongfully sets “Mail-Followup-To: guix-patches@gnu.org”.
>
>
> --- End Message ---