bug#55150: closed ([PATCH] gnu: Add qbe.)

[GNU bug Tracking System]

Your message dated Tue, 24 May 2022 21:44:26 +0200
with message-id <956d04d18e0dd7474550167906f0aadc09cac98d.camel@gmail.com>
and subject line Re: [PATCH v2] gnu: Add qbe.
has caused the debbugs.gnu.org bug report #53833,
regarding [PATCH] gnu: Add qbe.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
53833: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=53833
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] gnu: Add qbe. Date: Wed, 27 Apr 2022 07:29:32 -0400

Hello,

I’ve packaged the qbe compiler backend. I’m new to GUIX, so let me know if I 
messed anything up!

Jon

0001-gnu-Add-qbe.patch
Description: Binary data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [PATCH v2] gnu: Add qbe.
>
>
>
>
> Date: 
>
> Tue, 24 May 2022 21:44:26 +0200
>
>
>
>
> User-agent: 
>
> Evolution 3.42.1 
>
>
>
>
> Am Dienstag, dem 24.05.2022 um 08:50 +0200 schrieb Liliana Marie
> Prikler:
> > Hi, this is mostly a reminder for myself to push this soon.
> > 
> > Am Sonntag, dem 08.05.2022 um 21:21 +0100 schrieb (unmatched-
> > parenthesis:
> > > * gnu/packages/c.scm (qbe): New variable.
> > > 
> > > Signed-off-by: (unmatched-parenthesis <paren@disroot.org>
> > Don't add sign-off headers for your own patches, those are for
> > committers signing of other people's patches :)
> > 
> > > [...]
> > > +    (arguments
> > > +     (list #:make-flags
> > > +           #~(list (string-append "CC=" #$(cc-for-target))
> > > +                   (string-append "PREFIX=" #$output)
> > > +                   ;; `GUIXTARGET` is used instead of `TARGET` to
> > > avoid changing
> > > +                   ;; the meaning of tools/test.sh (which uses
> > > `TARGET` too).
> > > +                   (string-append "GUIXTARGET=" #$(or (%current-
> > > target-system)
> > > +                                                      (%current-
> > > system))))
> > > +           #:phases
> > > +           #~(modify-phases %standard-phases
> > > +               (add-after 'unpack 'allow-cross-compilation
> > > +                 (lambda _
> > > +                   (substitute* "Makefile"
> > > +                     (("`uname -m`") "$(GUIXTARGET)"))))
> > Instead of going through the variable, why not inline it into the
> > substitute*?
> > > +               (add-after 'allow-cross-compilation 'use-gcc-for-
> > > tests
> > > +                 (lambda _
> > > +                   (substitute* "tools/test.sh"
> > > +                     (("cc=\"cc -no-pie\"")
> > > +                      (string-append "cc=\"${CC} -no-pie\"")))))
> > > +               (delete 'configure))))
> > > +    (supported-systems (list "x86_64-linux" "aarch64-linux"
> > > "riscv64-linux"))
> > > +    (synopsis "Simple compiler backend")
> > > +    (description "QBE is a small compiler backend using an SSA-
> > > based
> > > intermediate
> > > +language as input.")
> > > +    (home-page "https://c9x.me/compile/";)
> > > +    (license license:expat))))
> > 
> > Otherwise LGTM.
> Applied with the above as well as my liberal interpretation of what
> passes as `guix style'.
>
> Cheers
>
>
> --- End Message ---