emacs-bug-tracker
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#52167: closed (29.0.50; [ada-mode] Preserve default value of project

From: GNU bug Tracking System
Subject: bug#52167: closed (29.0.50; [ada-mode] Preserve default value of project-read-file-name-function)
Date: Sat, 28 May 2022 11:17:02 +0000 
Your message dated Sat, 28 May 2022 04:15:57 -0700
with message-id <86pmjx9ac2.fsf@stephe-leake.org>
and subject line 29.0.50; [ada-mode] Preserve default value of 
project-read-file-name-function
has caused the debbugs.gnu.org bug report #52167,
regarding 29.0.50; [ada-mode] Preserve default value of 
project-read-file-name-function
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
52167: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=52167
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: 29.0.50; [ada-mode] Preserve default value of project-read-file-name-function Date: Sun, 28 Nov 2021 21:39:22 +0100 
Package: emacs, ada-mode
X-Debbugs-CC: ada-mode-users@nongnu.org

Hello,

ada-mode depends on uniquify-files, which ends with this:

> ;;;###autoload
> (setq-default project-read-file-name-function #'uniq-file-read)

This unconditionally changes the prompt for project-find-file at
startup.  I think this is a bit of an overreach: users who install
ada-mode are not necessarily looking for a new project-find-file prompt
for *all* their projects, including those unrelated to Ada.

I'm attaching

- a patch for uniquify-files to remove the above snippet, and add a bit
  of commentary explaining how to opt in to uniq-file-read,

- a patch for ada-mode to explicitly let-bind
  project-read-file-name-function before calling project-find-file,

- two more patches for ada-mode, which I didn't squash with the first
  one because I'm not 100% sure they are desirable: one to make
  ada-find-file support future Emacs versions; another to use
  ada-find-file in ada-mode-menu.

Let me know if this needs more work; thanks for your time.

Attachment: 0001-Preserve-default-value-of-project-read-file-name-fun.patch
Description: Text Data

Attachment: 0001-Explicitly-bind-project-read-file-name-function.patch
Description: Text Data

Attachment: 0002-ada-mode.el-ada-mode-menu-Prefer-ada-find-file.patch
Description: Text Data

Attachment: 0003-ada-mode.el-ada-find-file-Support-future-Emacs-versi.patch
Description: Text Data

In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo 
version 1.16.0)
 of 2021-11-26 built on hirondell
Repository revision: 11860f89a593a8cfe7efb94e86370bbbe4318fba
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Debian GNU/Linux 11 (bullseye)

Configured using:
 'configure --with-xwidgets --with-cairo --with-gconf --with-xinput2'

Configured features:
ACL CAIRO DBUS FREETYPE GCONF GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ
JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES
NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF
TOOLKIT_SCROLL_BARS X11 XDBE XIM XINPUT2 XPM XWIDGETS GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

--- End Message ---
--- Begin Message --- Subject: 29.0.50; [ada-mode] Preserve default value of project-read-file-name-function Date: Sat, 28 May 2022 04:15:57 -0700 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (windows-nt) 
Closed by ada-mode version 7.2.1, uniquify-files version 1.0.4.
-- 
-- Stephe

--- End Message ---
reply via email to
[Prev in Thread] Current Thread [Next in Thread]