--- Begin Message ---
|
Subject: |
package-location is wrong for transformed packages |
|
Date: |
Tue, 26 Apr 2022 21:48:49 -0400 |
Hi Guix!
--8<---------------cut here---------------start------------->8---
> ,import (gnu packages) (guix packages)
> (car (find-packages-by-name "python2-pyalsaaudio"))
$1 = #<package python2-pyalsaaudio@0.8.4 gnu/packages/audio.scm:4327
7f2b76fab160>
> (package-definition-location-code package $1)
$2 = #f
> (package-definition-location $2)
$3 = #<<location> file: "gnu/packages/audio.scm" line: 4327 column: 2>
--8<---------------cut here---------------end--------------->8---
This is wrong though, and gives the location of the parent package (the
one it inherited from). This seems to be made on purpose (?) given the
code in (gnu build-system python):
--8<---------------cut here---------------start------------->8---
(package/inherit p
(location (package-location p))
^ Here, we explicitly set the location to that of its parent.
(name (let ((name (package-name p)))
(string-append new-prefix
(if (string-prefix? old-prefix name)
(substring name
(string-length old-prefix))
name))))
(arguments
(let ((python (if (promise? python)
(force python)
python)))
(ensure-keyword-arguments (package-arguments p)
`(#:python ,python)))))
--8<---------------cut here---------------end--------------->8---
Another related issue for package-with-python2 packages:
--8<---------------cut here---------------start------------->8---
> (package-definition-location-code $1)
$4 = #f
--8<---------------cut here---------------end--------------->8---
I was expecting to use this to get rid of all leaf Python 2 packages,
but it seems that may not work (as easily as I'd hoped).
Thanks,
Maxim
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#55139: package-location is wrong for transformed packages |
|
Date: |
Wed, 08 Jun 2022 17:29:08 -0400 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) |
Hi Ludovic,
Ludovic Courtès <ludo@gnu.org> writes:
> Hi!
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
>> Yeah, I ended up with this [0]:
>>
>> (define (locate-package-via-git name)
>> "Return the location object corresponding to package NAME, searched via
>> git."
>> (let* ((input-pipe (open-pipe* OPEN_READ
>> "git" "grep" "-n" "--column"
>> (format #f "^(define-public ~a$" name)))
>> (output (get-string-all input-pipe)) ;file:line:column:match
>> (exit-val (status:exit-val (close-pipe input-pipe))))
>> (case exit-val
>> ((0)
>> (let ((components (string-split output #\:)))
>> (location
>> (first components) ;file
>> (string->number (second components)) ;1-indexed line
>> ;; FIXME: Comment discrepancy in (guix diagnostics), which
>> ;; says the column is 0-indexed.
>> (and=> (string->number (third components)) 1-)))) ;0-indexed column
>> ((1) #f) ;no match
>> (else (error "git grep failed with status" exit-val)))))
>>
>> and it does feel silly to have to shell out to git, but it did the job.
>>
>> Thanks,
>>
>> Maxim
>>
>> [0]
>> https://notabug.org/apteryx/guix-api-examples/src/master/purge-python2-packages.scm#L42
>
> Nice, it’s good to have these examples—and hopefully we’ll soon be able
> to remove a whole bunch of ‘python2-’ packages!
>
> As for ‘package-definition-location’, I don’t think we can reasonably do
> any better, so I’m tempted to close the bug.
OK; thanks for your input.
At least it'll be recorded somewhere for the next person stumbling on
this behavior to discover.
Maxim
--- End Message ---