bug#56213: closed ([PATCH] gnu: Add maven-doxia-core)

[GNU bug Tracking System]

Your message dated Sat, 25 Jun 2022 22:25:59 +0200
with message-id <20220625222559.5e92b63f@sybil.lepiller.eu>
and subject line Re: [bug#56213] [PATCH] gnu: Add maven-doxia-core
has caused the debbugs.gnu.org bug report #56213,
regarding [PATCH] gnu: Add maven-doxia-core
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
56213: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56213
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] gnu: Add maven-doxia-core Date: Sat, 25 Jun 2022 13:26:09 +0300 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)

Hello,

this patch adds "Maven Doxia Core" under the name 'maven-doxia-core'.

0001-gnu-Add-maven-doxia-core.patch
Description: Text Data

Thanks,

- Artyom

-- 
Artyom "avp" Poptsov <poptsov.artyom@gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

signature.asc
Description: PGP signature

--- End Message ---

--- Begin Message --- Subject: Re: [bug#56213] [PATCH] gnu: Add maven-doxia-core Date: Sat, 25 Jun 2022 22:25:59 +0200

Pushed to master as d039f9dc151eed8017a7f54682dbf713221b8005, thank you!

A few answers below:

Le Sat, 25 Jun 2022 15:14:58 +0300,
"Artyom V. Poptsov" <poptsov.artyom@gmail.com> a écrit :

> Hello Julien.
> 
> > Thanks for the patch!  
> 
> Thanks for taking your time for reviewing my patch.  :-)
> 
> > Missing full stop at the end of the subject line.  
> 
> Okay, added a full-stop.
> 
> FWIW, I'm usually following those rules when writing commit messages:
>   https://cbea.ms/git-commit/#end
> 
> The rules explicitly say that a committer should not add a full-stop
> at the end of the first line.

We follow our own rules that mandate a full stop. I thought I could
send you to the manual, but apart a vague mention of the ChangeLog
format, I can't find the rules. Have we always applied such strict
rules without writing them down properly?

> 
> However, 'guix lint' gave me the following warning:
> --8<---------------cut here---------------start------------->8---
> /home/avp/src/dist/guix/gnu/packages/maven.scm:3943:2:
> maven-doxia-core@2.0.0-M2: propagated inputs plexus-parent-pom@5.1
> and plexus-parent-pom@4.0 collide --8<---------------cut
> here---------------end--------------->8---
> 
> I don't know yet how to properly fix that; probably the issue is that
> I made all the inputs propagated, but I don't see how to differentiate
> them looking at the Doxia Core 'pom.xml'.

You can ignore these issues about parent poms. There's no real
collision except for the package name. No files in common between the
two packages, so that's fine. Nothing we can do anyway.

pgpPv3CYzXUi0.pgp
Description: Signature digitale OpenPGP

--- End Message ---