bug#56257: closed ([PATCH] fenics: Do not use mpirun for tests)

[GNU bug Tracking System]

Your message dated Wed, 03 Aug 2022 12:04:50 +0200
with message-id <87a68lve0t.fsf_-_@gnu.org>
and subject line Re: bug#56257: [PATCH] fenics: Do not use mpirun for tests
has caused the debbugs.gnu.org bug report #56257,
regarding [PATCH] fenics: Do not use mpirun for tests
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
56257: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56257
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] fenics: Do not use mpirun for tests Date: Mon, 27 Jun 2022 11:24:49 +0000

Hi guix,


the fenics package tests fail and it looks like the tests are run 3
times concurrently. Every test name is printed three times in the build
log, for example here:

https://ci.guix.gnu.org/build/1039880/log/raw

This is the maximum number of parallel jobs of the test run and if I
increase it, I get more print outputs.

AFAIK, pytest doesn't support mpi, so I don't see why the tests are
executed this way.

Anyhow, in the attached patch, the tests are executed directly using
pytest. This prevents the tests from getting stuck and subsequently I
discovered a failure in XDMF tests. With this test also disabled, the
package builds fine for me.

Maybe a fenics or mpi expert can tell if this patch makes sense?

Best regards,
Ontje

0001-gnu-fenics-Do-not-mpirun-tests.patch
Description: 0001-gnu-fenics-Do-not-mpirun-tests.patch

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#56257: [PATCH] fenics: Do not use mpirun for tests
>
>
>
>
> Date: 
>
> Wed, 03 Aug 2022 12:04:50 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
>
>
>
>
> Hi,
>
> (Sorry for the delay.)
>
> "Paul A. Patience" <paul@apatience.com> skribis:
>
> > Ludovic Courtès writes:
> >> Good question.  Paul, do you remember the reasons for doing so?
> >
> > If I'm the Paul you're referring to, it would be better to CC me in the
> > future, as I'm not subscribed to the list and only intermittently check
> > it (which happens more often when I'm submitting patches).
>
> I actually Cc’d Paul Garlick, but maybe Debbugs ate the Cc: field?
>
> > I'm no expert in MPI and pytest, but it does seem that pytest_mpi [1] is
> > recommended when combining the two, and there are no instances of
> > @pytest.mark.mpi in the fenics repository.
> > Further, running pytest tests under MPI is accomplished with [2]:
> >
> >   mpirun -n 2 python -m pytest --with-mpi
> >
> > In other words, it seems as if the current tests are repeated in
> > parallel, as Ontje discovered.
> >
> > The patch looks good to me.
>
> Alright, applied.
>
> Thanks!
>
> Ludo’.
>
>
> --- End Message ---