emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#55360: closed ([Installer] ‘guix system init’ displays dots instead


From: GNU bug Tracking System
Subject: bug#55360: closed ([Installer] ‘guix system init’ displays dots instead of progress bars)
Date: Thu, 20 Oct 2022 14:41:02 +0000

Your message dated Thu, 20 Oct 2022 16:40:08 +0200
with message-id <875ygepnhz.fsf@gnu.org>
and subject line Re: bug#58375: Installer does not show what is being downloaded
has caused the debbugs.gnu.org bug report #55360,
regarding [Installer] ‘guix system init’ displays dots instead of progress bars
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
55360: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55360
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [Installer] ‘guix system init’ displays dots instead of progress bars Date: Wed, 11 May 2022 11:23:42 +0200 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
Hi!

I’ve used an installer built from this commit:

--8<---------------cut here---------------start------------->8---
Generation 214  May 02 2022 21:44:14    (current)
  guix 6b588da
    repository URL: https://git.savannah.gnu.org/git/guix.git
    branch: master
    commit: 6b588da368c77cde82ea2f22ca315116228777ad
--8<---------------cut here---------------end--------------->8---

During installation, ‘guix system init’ displays dots instead of
progress bars for downloads and such.

This suggests that ‘display-download-progress’ gets #:tty? #f.  This may
be a side effect of running it in a pipe in
‘run-external-command-with-handler’.

Thoughts?

Ludo’.



--- End Message ---
--- Begin Message --- Subject: Re: bug#58375: Installer does not show what is being downloaded Date: Thu, 20 Oct 2022 16:40:08 +0200 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
Hey,

Thanks for having a look!

> I haven’t actually tested the patch but it LGTM.  One thing to check is
> whether ‘terminal-window-size’ returns something sensible for the
> pseudo-terminal; it could be that we need an extra ioctl so the
> pseudo-terminal has the same size as the actual terminal.

Well it returns 0 for all fields, but I tested on several screen sizes
and everything seems fine so I went ahead.

While testing I noticed two new issues though:

1. When the disk is GPT partitionned there is no confirmation page in
  "run-label-page". Something I missed in #57232.

2. When there is an exception in run-external-command-with-handler/tty
    for instance, the backtrace page is displayed in the PTY and the
    keyboard shortcuts do not work anymore.

I'll address point 1 shortly but could use some advice for point 2.

Thanks,

Mathieu


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]