bug#59661: closed ([PATCH 0/3] Add e2fsprogs to %base-packages-utils.)

[GNU bug Tracking System]

Your message dated Mon, 05 Dec 2022 11:44:50 -0500
with message-id <878rjl6br1.fsf_-_@gmail.com>
and subject line Re: bug#59661: [PATCH 0/3] Add e2fsprogs to 
%base-packages-utils.
has caused the debbugs.gnu.org bug report #59661,
regarding [PATCH 0/3] Add e2fsprogs to %base-packages-utils.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
59661: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59661
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/3] Add e2fsprogs to %base-packages-utils.
>
>
>
>
> Date: 
>
> Mon, 28 Nov 2022 14:18:31 -0500
>
>
>
>
> Hi Guix,
>
> Here's a simple series adjusting some annoyance noticed by someone on
> guix-help (no e2fsprogs in installer) and by myself (no lsattr/chattr on my
> system).
>
> Thank you,
>
> Maxim Cournoyer (3):
>   system: Rename and move %base-packages-disk-utilities.
>   install: Add missing e2fsprogs utility.
>   system: Add e2fsprogs to %base-packages-utils.
>
>  gnu/system.scm         | 18 ++----------------
>  gnu/system/install.scm | 17 ++++++++++++++++-
>  2 files changed, 18 insertions(+), 17 deletions(-)
>
>
> base-commit: 059d38dc3f8b087f4a42df586daeb05761ee18d7
> -- 
> 2.38.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#59661: [PATCH 0/3] Add e2fsprogs to %base-packages-utils.
>
>
>
>
> Date: 
>
> Mon, 05 Dec 2022 11:44:50 -0500
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
>
>
>
>
> Hi,
>
> Ludovic Courtès <ludo@gnu.org> writes:
>
> > Ludovic Courtès <ludo@gnu.org> skribis:
> >
> >> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
> >>
> >>> * gnu/system/install.scm (%installer-disk-utilities): Add e2fsprogs.
> >>
> >> LGTM!
> >>
> >> e2fsprogs binaries are indeed missing from $PATH in
> >> guix-system-install-1.4.0rc1.*.iso; I’ll cherry-pick it on
> >> ‘version-1.4.0’.
> >>
> >> What I don’t get is that our manual installation tests should have
> >> caught this issue because they use ‘mkfs.ext4’ and expect to have it in
> >> $PATH.  I’ll take a look…
> >
> > Got it: Mathieu worked around it in
> > 0f66ef9aa99d2043abccbc80d858bdeca57534ac by explicitly adding e2fsprogs
> > and the installation system used by the tests:
> >
> >   commit 0f66ef9aa99d2043abccbc80d858bdeca57534ac
> >   Author: Mathieu Othacehe <othacehe@gnu.org>
> >   Date:   Fri Sep 30 15:19:36 2022 +0200
> >
> >       tests: install: Fix iso-image-installer test.
> >
> >       This is a follow-up of: 45eac6cdf5c8d9d7b0c564b105c790d2d2007799.
> >       It fixes the following error:
> >
> >       + mkfs.ext4 -L my-root /dev/vda2
> >       sh: line 12: mkfs.ext4: command not found
> >
> >       * gnu/tests/install.scm (%test-iso-image-installer): Add e2fsprogs to 
> > the
> >       appended packages.
> >
> > We should be able to revert this commit once the installer provides
> > e2fsprogs by default.
>
> I applied this series, reverted 0f66ef9aa99d2043abccbc80d858bdeca57534ac
> as suggested above, ran:
>
> --8<---------------cut here---------------start------------->8---
> make check-system TESTS=iso-image-installer
> --8<---------------cut here---------------end--------------->8---
>
> And pushed!
>
> Closing.
>
> -- 
> Thanks,
> Maxim
>
>
> --- End Message ---