bug#59622: closed (29.0.50; [PATCH] Regression in Eshell's handling of escaped newlines)

[GNU bug Tracking System]

Your message dated Thu, 8 Dec 2022 16:59:53 -0800
with message-id <2443e376-23f8-594d-5e4c-bb3f2cc69557@gmail.com>
and subject line Re: bug#59622: 29.0.50; [PATCH] Regression in Eshell's 
handling of escaped newlines
has caused the debbugs.gnu.org bug report #59622,
regarding 29.0.50; [PATCH] Regression in Eshell's handling of escaped newlines
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
59622: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59622
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: 29.0.50; [PATCH] Regression in Eshell's handling of escaped newlines Date: Sat, 26 Nov 2022 16:36:59 -0800

Starting from "emacs -Q -f eshell":

  # Emacs 28
  ~ $ echo foo\
  bar

  foobar

  # Emacs 29
  ~ $ echo foo\
  bar

  foo
  bar

That is, Emacs 28 used to treat escaped newlines in the way you'd expect from other shells: it expands to the empty string. Now in Emacs 29, it inserts a literal newline.

There's also a similar bug when doing this inside double-quotes:

  # Emacs 28
  ~ $ echo "foo\
  bar"

  ("foo\\" "bar")

  # Emacs 29
  ~  $ echo "foo\
  bar"

  foo\
  bar

Here, both cases are wrong. In Emacs 29, it inserts the literal backslash+newline combo, but Emacs 28 is even worse: it returns a list of two elements! Wrapping arguments in quotes should always produce a string in Eshell.

0001-Treat-escaped-newlines-in-Eshell-as-the-empty-string.patch
Description: Text document

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#59622: 29.0.50; [PATCH] Regression in Eshell's handling of escaped newlines
>
>
>
>
> Date: 
>
> Thu, 8 Dec 2022 16:59:53 -0800
>
>
>
>
> On 12/7/2022 9:47 PM, Jim Porter wrote:
> > I'll leave this open until I merge the small cleanup patch to master 
> > once my first patch has gotten there.
>
> Pushed my followup patch to master as 
> 8c01829c01ca81c990eadf34bc16794b65d62c70. Closing this now.
>
>
> --- End Message ---