bug#59886: closed (Manual error in (elisp) Searching Keymaps regarding keymap char properties?)

[GNU bug Tracking System]

Your message dated Sat, 10 Dec 2022 15:07:20 +0200
with message-id <831qp7xv93.fsf@gnu.org>
and subject line Re: bug#59886: Manual error in (elisp) Searching Keymaps 
regarding keymap char properties?
has caused the debbugs.gnu.org bug report #59886,
regarding Manual error in (elisp) Searching Keymaps regarding keymap char 
properties?
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
59886: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59886
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> Manual error in (elisp) Searching Keymaps regarding keymap char properties?
>
>
>
>
> Date: 
>
> Wed, 07 Dec 2022 17:21:36 +0100
>
>
>
>
> User-agent: 
>
> mu4e 1.8.9; emacs 28.2
>
>
>
>
>
> Hello,
>
> The psuedo-Lisp code presented in the manual (elisp) Searching 
> Keymaps says:
>
> (if (get-text-property (point) 'local-map)
>   (FIND-IN (get-char-property (point) 'local-map))
> (FIND-IN (current-local-map)))
>
> Why does the condition use `get-text-property', but then the 
> consequent uses `get-char-property'? Shouldn't they both be 
> `get-char-property'? According to (elisp) Active Keymaps:
>
> "If there is a 'local-map' /text or overlay/ property at point, 
> that specifies the local keymap to use, in place of the buffer's 
> default local keymap."
>
> Am I missing something?
>
> Additionally, perhaps the two paragraphs in (elisp) Active Keymaps 
> that mention the `keymap` and the `local-map' property (search for 
> "property") should be reworded slightly to emphasize that the 
> search prefers the overlay property over the text property, since 
> that's how `get-char-property' is documented to work. Maybe change 
> the ordering of "text or overlay" to "overlay or text", along with 
> an explicit emphasis?
>
> hokomo
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#59886: Manual error in (elisp) Searching Keymaps regarding keymap char properties?
>
>
>
>
> Date: 
>
> Sat, 10 Dec 2022 15:07:20 +0200
>
>
>
>
> > From: hokomo <hokomo@airmail.cc>
> > Date: Wed, 07 Dec 2022 17:21:36 +0100
> > 
> > 
> > Hello,
> > 
> > The psuedo-Lisp code presented in the manual (elisp) Searching 
> > Keymaps says:
> > 
> > (if (get-text-property (point) 'local-map)
> >    (FIND-IN (get-char-property (point) 'local-map))
> >  (FIND-IN (current-local-map)))
> > 
> > Why does the condition use `get-text-property', but then the 
> > consequent uses `get-char-property'? Shouldn't they both be 
> > `get-char-property'? According to (elisp) Active Keymaps:
> > 
> > "If there is a 'local-map' /text or overlay/ property at point, 
> > that specifies the local keymap to use, in place of the buffer's 
> > default local keymap."
> > 
> > Am I missing something?
> > 
> > Additionally, perhaps the two paragraphs in (elisp) Active Keymaps 
> > that mention the `keymap` and the `local-map' property (search for 
> > "property") should be reworded slightly to emphasize that the 
> > search prefers the overlay property over the text property, since 
> > that's how `get-char-property' is documented to work. Maybe change 
> > the ordering of "text or overlay" to "overlay or text", along with 
> > an explicit emphasis?
>
> Thanks, I've changed the example to use get-char-property.
>
>
> --- End Message ---