emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#59989: closed ([PATCH] tests: Fix txinfo-include test for texinfo 7.


From: GNU bug Tracking System
Subject: bug#59989: closed ([PATCH] tests: Fix txinfo-include test for texinfo 7.x)
Date: Mon, 12 Dec 2022 22:52:03 +0000

Your message dated Mon, 12 Dec 2022 15:51:03 -0700
with message-id <202212122251.2BCMp35N014304@freefriends.org>
and subject line Re: [bug#59989] [PATCH] tests: Fix txinfo-include test for 
texinfo 7.x
has caused the debbugs.gnu.org bug report #59989,
regarding [PATCH] tests: Fix txinfo-include test for texinfo 7.x
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
59989: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59989
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [PATCH] tests: Fix txinfo-include test for texinfo 7.x Date: Mon, 12 Dec 2022 07:28:38 +0100
From: Frédéric Bérat <fberat@redhat.com>

Texinfo modified its behavior regarding apostrophes, which are now
replaced by UTF-8 right single quotes by default.
It looks like this was supposed to be the default for few years already,
but this behavior was broken so far.

Use the @verb construct in order to ensure that the quotes are kept
has-is, so that we can easily grep for "GNU's Not Unix".
---
 t/txinfo-include.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/txinfo-include.sh b/t/txinfo-include.sh
index 8a15f01b0..40b61878f 100644
--- a/t/txinfo-include.sh
+++ b/t/txinfo-include.sh
@@ -62,7 +62,7 @@ END
 cat > three.texi << 'END'
 @node three
 @chapter Chapter two
-GNU's Not Unix.
+@verb{.GNU's Not Unix..}
 END
 
 mkdir sub
-- 
2.38.1




--- End Message ---
--- Begin Message --- Subject: Re: [bug#59989] [PATCH] tests: Fix txinfo-include test for texinfo 7.x Date: Mon, 12 Dec 2022 15:51:03 -0700
Hi Frederic,

    Texinfo modified its behavior regarding apostrophes, which are now
    replaced by UTF-8 right single quotes by default.

Sorry to hear it, but not surprised.

    -GNU's Not Unix.
    +@verb{.GNU's Not Unix..}

I don't think there's any guarantee that verb quotes will also be
"helpfully" changed in the future. One wouldn't think so, but ...

So instead, I changed the test document to avoid apostrophes. Pushed the
below. Hope it flies. --thanks, karl.

--- a/t/txinfo-include.sh
+++ b/t/txinfo-include.sh
@@ -28,6 +28,9 @@ main_TEXINFOS = one.texi two.texi three.texi
 sub_more_TEXINFOS = sub/desc.texi sub/hist.texi
 END
 
+# We avoid apostrophes in the test document since Texinfo
+# turns them into UTF-8, which is not easy to grep.
+#
 cat > main.texi << 'END'
 \input texinfo
 @setfilename main.info
@@ -61,8 +64,8 @@ END
 
 cat > three.texi << 'END'
 @node three
-@chapter Chapter two
-GNU's Not Unix.
+@chapter Chapter three
+Quux quux quux.
 END
 
 mkdir sub
@@ -106,7 +109,7 @@ check_info_contents ()
   srcdir=${1-.}
   $FGREP "Foo bar, baz."                        $srcdir/main.info
   $FGREP "Blah Blah Blah."                      $srcdir/main.info
-  $FGREP "GNU's Not Unix."                      $srcdir/main.info
+  $FGREP "Quux quux quux."                      $srcdir/main.info
   $FGREP 'It does something, really.'           $srcdir/sub/more.info
   $FGREP 'It was written somehow.'              $srcdir/sub/more.info
 }

compile finished at Mon Dec 12 14:48:33 2022


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]