bug#60105: closed ([PATCH] Add yaml-ts-mode)

[GNU bug Tracking System]

Your message dated Fri, 16 Dec 2022 14:55:34 -0800
with message-id <C38AB5EC-0595-4BC6-994F-E88DAA8BD0D7@gmail.com>
and subject line Re: bug#60105: [PATCH] Add yaml-ts-mode
has caused the debbugs.gnu.org bug report #60105,
regarding [PATCH] Add yaml-ts-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
60105: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60105
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] Add yaml-ts-mode Date: Thu, 15 Dec 2022 22:19:58 +0000

X-Debbugs-CC: casouri@gmail.com

0001-Add-yaml-ts-mode.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#60105: [PATCH] Add yaml-ts-mode
>
>
>
>
> Date: 
>
> Fri, 16 Dec 2022 14:55:34 -0800
>
>
>
>
> Randy Taylor <dev@rjt.dev> writes:
>
> > On Thursday, December 15th, 2022 at 19:20, Stefan Kangas 
> > <stefankangas@gmail.com> wrote:
> >> 
> >> Randy Taylor dev@rjt.dev writes:
> >> 
> >> > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
> >> > index 9c5a361df7..4319623e64 100644
> >> > --- a/lisp/progmodes/eglot.el
> >> > +++ b/lisp/progmodes/eglot.el
> >> > @@ -224,7 +224,7 @@ eglot-server-programs
> >> > ((tex-mode context-mode texinfo-mode bibtex-mode)
> >> > . ,(eglot-alternatives '("digestif" "texlab")))
> >> > (erlang-mode . ("erlang_ls" "--transport" "stdio"))
> >> > - (yaml-mode . ("yaml-language-server" "--stdio"))
> >> > + ((yaml-mode yaml-ts-mode) . ("yaml-language-server" "--stdio"))
> >> 
> >> 
> >> This is a nit, but I think it might make more sense to users if we put
> >> the built-in mode first in the list. After all, the one we ship with
> >> Emacs is, or will be, the standard mode.
> >
> > Sounds good to me. I'll submit another patch tomorrow making that change for 
> > the rest of the modes we've added (unless someone beats me to it).
> >
> > Attached is a new patch that applies cleanly against emacs-29 and has 
> > yaml-ts-mode come first for eglot.
> >
>
> LGTM, I applied the patch, thanks!
>
> Yuan
>
>
> --- End Message ---