--- Begin Message ---
|
Subject: |
29.0.60; Infinite loop when there are cyclic path in the parse tree |
|
Date: |
Tue, 13 Dec 2022 16:11:01 -0800 |
This is not really an Emacs bug, but either tree-siter-c or
tree-sitter’s. I’m putting it out here so that if I’m hit by a bus
tomorrow, and treesit-search-forward-goto and friends hang,
we (eh, you) know what’s going on.
I’ve submitted an issue here:
https://github.com/tree-sitter/tree-sitter-c/issues/119
So far, I’ve only observed this in that specific edge case.
Yuan
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#60054: 29.0.60; Infinite loop when there are cyclic path in the parse tree |
|
Date: |
Sun, 18 Dec 2022 00:10:23 -0800 |
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Yuan Fu <casouri@gmail.com>
>> Date: Sat, 17 Dec 2022 15:28:01 -0800
>> Cc: 60054@debbugs.gnu.org
>>
>> > In this particular case, it is the siblings’ parent that equals to the
>> > node. Ie, node->sibling->parent = node. If your intention is to protect
>> > us from this particular case, switching to use cursors will avoid this
>> > bug.
>>
>> Ok, I made the change to use cursor API with tests. Hopefully this is
>> the last time we need to change treesit.c before release.
>
> This broke the Windows build (I fixed it). You cannot start using new
> tree-sitter functions without adding the boilerplate code for loading
> them dynamically from the shared library at run time.
Ah right, it evaded my mind, sorry about that.
>> The node->sibling->parent = node cyclic path should be fixed by this
>> change, do you still want checks for it?
>
> If that problem can never happen, there's no need for the checks.
Cool. I’m closing this.
Yuan
--- End Message ---