bug#60161: closed ([PATCH] Allow customising windmove user options with an empty prefix)

[GNU bug Tracking System]

Your message dated Sun, 18 Dec 2022 11:46:29 +0000
with message-id <87zgblx7ca.fsf@posteo.net>
and subject line Re: bug#60161: [PATCH] Allow customising windmove user options 
with an empty prefix
has caused the debbugs.gnu.org bug report #60161,
regarding [PATCH] Allow customising windmove user options with an empty prefix
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
60161: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60161
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] Allow customising windmove user options with an empty prefix Date: Sat, 17 Dec 2022 15:04:41 +0000

Tags: patch


I just switched to setopt, and noticed a few errors.  Among these was
`windmove-default-keybindings', which didn't want to set

  (setopt windmove-default-keybindings '(nil . nil))

while

  (setopt windmove-default-keybindings '("C-c" . nil))

is allowed.  The mistake appears to be that the option type is
misconfigured, and believes the car must be a keybinding, which hasn't
been the case since Emacs 28.  The patch below updates the type,
resolving this issue.

In GNU Emacs 29.0.60 (build 5, x86_64-pc-linux-gnu, GTK+ Version
 3.24.35, cairo version 1.16.0) of 2022-12-14 built on quetzal
Repository revision: 622838b957e240d700585050e9ddbd036e690513
Repository branch: emacs-29
System Description: Debian GNU/Linux bookworm/sid

Configured using:
 'configure --with-pgtk --with-imagemagick'

0001-Allow-customising-windmove-user-options-with-an-empt.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#60161: [PATCH] Allow customising windmove user options with an empty prefix
>
>
>
>
> Date: 
>
> Sun, 18 Dec 2022 11:46:29 +0000
>
>
>
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Philip Kaludercic <philipk@posteo.net>
> >> Date: Sat, 17 Dec 2022 15:04:41 +0000
> >> 
> >> I just switched to setopt, and noticed a few errors.  Among these was
> >> `windmove-default-keybindings', which didn't want to set
> >> 
> >>   (setopt windmove-default-keybindings '(nil . nil))
> >> 
> >> while
> >> 
> >>   (setopt windmove-default-keybindings '("C-c" . nil))
> >> 
> >> is allowed.  The mistake appears to be that the option type is
> >> misconfigured, and believes the car must be a keybinding, which hasn't
> >> been the case since Emacs 28.  The patch below updates the type,
> >> resolving this issue.
> >
> > Thanks, please install on the release branch.
>
> Pushed
>
>
> --- End Message ---