bug#60108: closed ([PATCH] gnu: musescore: Fix build.)

[GNU bug Tracking System]

Your message dated Mon, 19 Dec 2022 18:19:08 +0100
with message-id <87r0wvcnw3.fsf@nicolasgoaziou.fr>
and subject line Re: [bug#60108] [PATCH v2] gnu: musescore: Fix build.
has caused the debbugs.gnu.org bug report #60108,
regarding [PATCH] gnu: musescore: Fix build.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
60108: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60108
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: musescore: Fix build.
>
>
>
>
> Date: 
>
> Fri, 16 Dec 2022 00:31:00 +0100
>
>
>
>
> * gnu/packages/music.scm (musescore)[snippet]: Remove crashpad_handler and
> associated install actions.
> [arguments]<#:configure-flags>: Add “-DBUILD_DIAGNOSTICS=OFF”.
> ---
>  gnu/packages/music.scm | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index 614eb57791..0d7fb21701 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -4787,14 +4787,19 @@ (define-public musescore
>          (base32 "16rcwr6fzghv8100syzicabqg8jqvng3zzsi6h3ja4zkp9hcbkcr"))
>         (modules '((guix build utils)))
>         (snippet
> -        ;; Remove unused libraries.
>          '(begin
> +           ;; Remove unused libraries...
>             (for-each delete-file-recursively
> -                     '("thirdparty/freetype"))))))
> +                     '("thirdparty/freetype"))
> +           ;; ... and precompiled binaries.
> +           (delete-file-recursively "src/diagnostics/crashpad_handler")
> +           (substitute* "src/diagnostics/CMakeLists.txt"
> +             (("install") "#install"))))))
>      (build-system qt-build-system)
>      (arguments
>       `(#:configure-flags
>         `("-DDOWNLOAD_SOUNDFONT=OFF"
> +         "-DBUILD_DIAGNOSTICS=OFF"
>           "-DMUSESCORE_BUILD_CONFIG=release"
>           "-DUSE_SYSTEM_FREETYPE=ON")
>         ;; There are tests, but no simple target to run.  The command used to
> -- 
> 2.38.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#60108] [PATCH v2] gnu: musescore: Fix build.
>
>
>
>
> Date: 
>
> Mon, 19 Dec 2022 18:19:08 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
>
>
>
>
> Hello,
>
> Vivien Kraus via Guix-patches via <guix-patches@gnu.org> writes:
>
> > From: Liliana Marie Prikler <liliana.prikler@gmail.com>
> >
> > * gnu/packages/music.scm (musescore)[snippet]: Remove crashpad_handler and
> > associated install actions.
> > [arguments]<#:configure-flags>: Add “-DBUILD_DIAGNOSTICS=OFF”.
> > [inputs]: Add qtquickcontrols-5.
>
> Thanks to you both.
>
> I added Vivien as a co-author and applied the patch. I'm closing this
> issue. Feel free to re-open it if you think something is missing.
>
> Regards,
> -- 
> Nicolas Goaziou
>
>
> --- End Message ---