bug#60037: closed (Update CDO to 2.1.0 and add libaec and eccodes)

[GNU bug Tracking System]

Your message dated Mon, 19 Dec 2022 18:31:12 +0000
with message-id <87y1r3nskf.fsf@kitej>
and subject line Re: [bug#60037] Update CDO to 2.1.0 and add libaec and eccodes
has caused the debbugs.gnu.org bug report #60037,
regarding Update CDO to 2.1.0 and add libaec and eccodes
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
60037: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60037
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: Update CDO to 2.1.0 and add libaec and eccodes Date: Tue, 13 Dec 2022 18:52:08 +0100 User-agent: mu4e 1.8.11; emacs 29.0.50

Hello Guix,

this patch series updates the Climate Data Operators package to version
2.1.0 and adds support for reading GRIB files by adding the libaec and
eccodes packages.

Could you please review the patches?

Thanks, Roman.

0001-gnu-Add-libaec.patch
Description: Text Data

From a8c693aa62cf4d5adf088493eaa95a1e9d9a06b6 Mon Sep 17 00:00:00 2001
From: r0man <roman@burningswell.com>
Date: Sat, 3 Dec 2022 13:16:02 +0100
Subject: [PATCH 2/3] gnu: Add eccodes.

* gnu/packages/geo.scm (eccodes): New variable.
---
 gnu/packages/geo.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/geo.scm b/gnu/packages/geo.scm
index d2836b0358..63fbfccab9 100644
--- a/gnu/packages/geo.scm
+++ b/gnu/packages/geo.scm
@@ -65,6 +65,7 @@ (define-module (gnu packages geo)
   #:use-module (gnu packages bison)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages build-tools)
+  #:use-module (gnu packages c)
   #:use-module (gnu packages check)
   #:use-module (gnu packages cmake)
   #:use-module (gnu packages compression)
@@ -79,6 +80,7 @@ (define-module (gnu packages geo)
   #:use-module (gnu packages flex)
   #:use-module (gnu packages fonts)
   #:use-module (gnu packages fontutils)
+  #:use-module (gnu packages gcc)
   #:use-module (gnu packages gettext)
   #:use-module (gnu packages gl)
   #:use-module (gnu packages glib)
@@ -122,6 +124,7 @@ (define-module (gnu packages geo)
   #:use-module (gnu packages textutils)
   #:use-module (gnu packages time)
   #:use-module (gnu packages tls)
+  #:use-module (gnu packages version-control)
   #:use-module (gnu packages web)
   #:use-module (gnu packages webkit)
   #:use-module (gnu packages wxwidgets)
@@ -151,6 +154,35 @@ (define-public libaec
 coded by grouping exponents and mantissa.")
     (license (list (license:non-copyleft "file://LICENSE.txt")))))
 
+(define-public eccodes
+  (package
+    (name "eccodes")
+    (version "2.27.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    
"https://confluence.ecmwf.int/download/attachments/45757960/eccodes-";
+                     version "-Source.tar.gz"))
+              (sha256
+               (base32
+                "16cw4v2d0kjq6gq04paqny0sh5jymn70w449mig7m5h3spzv7rgd"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:configure-flags '("-DENABLE_MEMFS=ON" "-DENABLE_PNG=ON")
+       #:validate-runpath? #f))
+    (inputs
+     (list git jasper libaec libjpeg-turbo libpng netcdf openjpeg))
+    (native-inputs
+     (list gfortran pkg-config perl python))
+    (home-page "https://confluence.ecmwf.int/display/ECC";)
+    (synopsis "Library for handling the GRIB, BUFR and GTS file formats")
+    (description "ecCodes is a package developed by @acronym{ECMWF, European
+Centre for Medium-Range Weather Forecasts} which provides an application
+programming interface and a set of tools for decoding and encoding messages in
+the @acronym{WMO, World Meteorological Organization} FM-92 GRIB, WMO FM-94
+BUFR and WMO GTS abbreviated header formats.")
+    (license license:asl2.0)))
+
 (define-public cdo
   (package
     (name "cdo")
-- 
2.38.1

0003-gnu-cdo-Update-to-2.1.0.patch
Description: Text Data

signature.asc
Description: PGP signature

--- End Message ---

--- Begin Message --- Subject: Re: [bug#60037] Update CDO to 2.1.0 and add libaec and eccodes Date: Mon, 19 Dec 2022 18:31:12 +0000

Roman Scherer <roman.scherer@burningswell.com> skribis:

>
> Hi Guillaume,
>
> thanks for looking at this patch series and sorry for the trouble. I
> just rebuild the patch series on top of the current master 3 times with
> the following command:
>
> ```
> ./pre-inst-env guix build --check --no-grafts --no-substitutes --rounds=3 cdo
> ```
>
> I see some tests are skipped, but the whole thing passed every time. I
> also don't remember seeing them failing a single time.
>
> I'm running this on the following system:
>
> ```
> Linux precision 5.15.0-56-generic #62-Ubuntu SMP Tue Nov 22 19:54:14 UTC 2022 
> x86_64 x86_64 x86_64 GNU/Linux
> ```
>
> And here are the logs of one of the test runs:
>
> [...]
>
> On what kind of system is this failing for you? What can we do?

On my main machine, with an AMD Ryzen 9 CPU with 32 threads, it failed
every time. On another machine, with an Intel I9 CPU with 16 threads, it
succeeded every time. It turns out that some tests can fail if the
machine has many threads, and adding '#:parallel-tests? #f' to the
'arguments' field fixes the issue.

I also changed the 'source' field of the libaec package to use
'git-fetch' instead of 'url-fetch', because archive files created
automatically by forges like gitlab can sometimes change in place and
have a different hash.

Patches pushed as d03b6fb0e3f0b81b35a9b35b89c213c144c59fe6 and
following. Thanks.

signature.asc
Description: PGP signature

--- End Message ---