emacs-bug-tracker
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#60189: closed ([PATCH] ert-x: Refactor `ert-with-test-buffer-selecte

From: GNU bug Tracking System
Subject: bug#60189: closed ([PATCH] ert-x: Refactor `ert-with-test-buffer-selected')
Date: Sat, 24 Dec 2022 07:19:02 +0000 
Your message dated Sat, 24 Dec 2022 09:17:58 +0200
with message-id <83wn6h5kyh.fsf@gnu.org>
and subject line Re: bug#60189: [PATCH] ert-x: Refactor 
`ert-with-test-buffer-selected'
has caused the debbugs.gnu.org bug report #60189,
regarding [PATCH] ert-x: Refactor `ert-with-test-buffer-selected'
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
60189: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60189
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [PATCH] ert-x: Refactor `ert-with-test-buffer-selected' Date: Mon, 19 Dec 2022 00:22:19 -0500 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 I think the attached patches can go on emacs-29 because `ert-with-test-buffer-selected' was added in 29. 

Patch 1:

    ; ert-x: Add test for buffer read-only state

    This test should have been included with commit
    29b7d740006fe2190a729bd1c30ccab9356cee36.

Patch 2:

    ; ert-x: Simplify `ert-with-test-buffer-selected'

Patch 3:

    ert-x: Move window selection logic to its own macro

    * lisp/emacs-lisp/ert-x.el (ert-with-buffer-selected): New macro to
    temporarily display a buffer in a selected window and evaluate a body.
    (ert-with-test-buffer-selected): Use the new macro.
    * test/lisp/whitespace-tests.el (ert-test-with-buffer-selected/*): Add
    tests.

Attachment: 0001-ert-x-Add-test-for-buffer-read-only-state.patch
Description: Text Data

Attachment: 0002-ert-x-Simplify-ert-with-test-buffer-selected.patch
Description: Text Data

Attachment: 0003-ert-x-Move-window-selection-logic-to-its-own-macro.patch
Description: Text Data

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


--- End Message ---
--- Begin Message --- Subject: Re: bug#60189: [PATCH] ert-x: Refactor `ert-with-test-buffer-selected' Date: Sat, 24 Dec 2022 09:17:58 +0200 
> Date: Mon, 19 Dec 2022 00:22:19 -0500
> From: Richard Hansen <rhansen@rhansen.org>
> 
> I think the attached patches can go on emacs-29 because 
> `ert-with-test-buffer-selected' was added in 29.

Thanks, installed.

--- End Message ---
reply via email to
[Prev in Thread] Current Thread [Next in Thread]