bug#60210: closed (30.0.50; tab-bar height not recalculated when face changes)

[GNU bug Tracking System]

Your message dated Mon, 26 Dec 2022 17:40:52 +0000
with message-id <f9fdb7b870a2b753780d@heytings.org>
and subject line Re: bug#60210: 30.0.50; tab-bar height not recalculated when 
face changes
has caused the debbugs.gnu.org bug report #60210,
regarding 30.0.50; tab-bar height not recalculated when face changes
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
60210: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60210
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 30.0.50; tab-bar height not recalculated when face changes
>
>
>
>
> Date: 
>
> Mon, 19 Dec 2022 23:04:25 +0000
>
>
>
>
> Steps:
>
> 1) emacs -Q (master "ae91da52335aafaff5405a49c23460082dfb460d")
>
> 2) Enable tab-bar:
>
>    (tab-bar-mode +1)
>
> 3) Change some face attribute of tab-bar to force increase the tab-bar
> height, e.g:
>
>    (set-face-attribute 'tab-bar nil :box 4)
>    (set-face-attribute 'tab-bar nil :height 1.2)
>
> Result: the new face is displayed and the tab-bar height is properly
> adjusted to reflect the new height.
>
> 4) Reset face attributes of tab-bar to force original height, e.g.:
>
>    (set-face-attribute 'tab-bar nil :box nil)
>    (set-face-attribute 'tab-bar nil :height 1.0)
>
> Result: the new face is displayed, but the tab-bar height is not
> properly adjusted to reflect the new height.
>
> ---
> Gabriel
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#60210: 30.0.50; tab-bar height not recalculated when face changes
>
>
>
>
> Date: 
>
> Mon, 26 Dec 2022 17:40:52 +0000
>
>
>
>
>
> > > > Thanks, this LGTM.  If you tested this with tab bars of more than a 
> > > > single line, including when tabs are removed so a single line is once 
> > > > again long enough, please install on the release branch.
> > >
> > > I did test it, but I don't use tab bars, so I'm not 110% sure.  Juri, 
> > > could you please test the patch?
> >
> > Thanks for the patch.  I tested it in emacs-29 with tab-bar-lines > 1 
> > and see no problems.
>
> Thanks!  Pushed (b14bbd108e), and closing.
>
>
>
> --- End Message ---