bug#60520: closed ([PATCH 0/4] Tests for 'guix refresh')

[GNU bug Tracking System]

Your message dated Sun, 08 Jan 2023 16:16:37 +0100
with message-id <875ydhukdm.fsf_-_@gnu.org>
and subject line Re: bug#60520: [PATCH 0/4] Tests for 'guix refresh'
has caused the debbugs.gnu.org bug report #60520,
regarding [PATCH 0/4] Tests for 'guix refresh'
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
60520: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60520
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/4] Tests for 'guix refresh'
>
>
>
>
> Date: 
>
> Tue,  3 Jan 2023 17:44:39 +0100
>
>
>
>
> Hi!
>
> Following the discussion at
> <https://lists.gnu.org/archive/html/guix-devel/2022-12/msg00311.html>,
> I thought it’s about time to have tests for the ‘guix refresh’ CLI
> (so far we had tests for importers, for (guix gnu-maintenance), and
> for (guix upstream), but that did not cover the logic in ‘guix refresh’
> itself as we’ve seen).
>
> The strategy is to define a “pseudo updater”: the test defines an
> environment variable that specifies which package updates the updater
> should simulate, and then we go on using ‘guix refresh’.
>
> Thoughts?
>
> Ludo’.
>
> Ludovic Courtès (4):
>   gnu-maintenance: Factorize 'false-if-networking-failure'.
>   gnu-maintenance: 'gnu' and 'gnu-ftp' predicates catch networking
>     errors.
>   import: stackage: Catch networking errors in predicate.
>   refresh: Add CLI tests.
>
>  Makefile.am              |   4 +-
>  guix/gnu-maintenance.scm |  31 ++++-------
>  guix/import/stackage.scm |  15 ++---
>  guix/import/test.scm     |  88 +++++++++++++++++++++++++++++
>  guix/import/utils.scm    |  24 +++++++-
>  tests/guix-refresh.sh    | 117 +++++++++++++++++++++++++++++++++++++++
>  6 files changed, 251 insertions(+), 28 deletions(-)
>  create mode 100644 guix/import/test.scm
>  create mode 100644 tests/guix-refresh.sh
>
>
> base-commit: 473692b812b4ab4267d9bddad0fb27787d2112ff
> -- 
> 2.38.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#60520: [PATCH 0/4] Tests for 'guix refresh'
>
>
>
>
> Date: 
>
> Sun, 08 Jan 2023 16:16:37 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
>
>
>
>
> Hi,
>
> Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:
>
> > Two mini remarks:
> >
> > +IFS=X
> >
> > What about using a symbol like underscore?
> >
> > + "guileX-r" \
> >
> > For symetry I'd write "-r guile".
>
> Good ideas.  I made those changes and pushed:
>
>   04f247be81 * refresh: Add CLI tests.
>   2e9c0e1ff6 * import: stackage: Catch networking errors in predicate.
>   472dd29f37 * gnu-maintenance: 'gnu' and 'gnu-ftp' predicates catch networking 
> errors.
>   f3edf29c67 * gnu-maintenance: Factorize 'false-if-networking-failure'.
>
> Thanks,
> Ludo’.
>
>
> --- End Message ---