bug#60626: closed (30.0.50; `buffer-live-p' sometimes returns t on killed buffers)

[GNU bug Tracking System]

Your message dated Wed, 11 Jan 2023 14:50:40 +0200
with message-id <83fschmdzz.fsf@gnu.org>
and subject line Re: bug#60626: 30.0.50; `buffer-live-p' sometimes returns t on 
killed buffers
has caused the debbugs.gnu.org bug report #60626,
regarding 30.0.50; `buffer-live-p' sometimes returns t on killed buffers
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
60626: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60626
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 30.0.50; `buffer-live-p' sometimes returns t on killed buffers
>
>
>
>
> Date: 
>
> Sat, 07 Jan 2023 12:44:47 +0000
>
>
>
>
> Hi,
>
> We are recently experiencing test failures using Emacs 28, Emacs 27, and
> Emacs 26 on CI (non-interactively):
>
> https://builds.sr.ht/~bzg/job/918602
>
> 2 unexpected results:
>    FAILED  ob-octave/graphics-file  ((should-not (buffer-live-p (get-buffer 
> "*Org-Babel Error Output*"))) :form (buffer-live-p #<killed buffer>) :value t)
>    FAILED  ob-octave/graphics-file-space  ((should-not (buffer-live-p 
> (get-buffer "*Org-Babel Error Output*"))) :form (buffer-live-p #<killed 
> buffer>) :value t)
>
> Note that (buffer-live-p #<killed buffer>) returns non-nil, which is
> unexpected.
>
> I am also able to reproduce locally using rake + podman:
>
> See https://git.sr.ht/~bzg/org-mode-tests/:
>
> 1. cd /path/to/org-mode-tests
> 2. ln -s /path/to/org ./org-mode
> 3. cd local
> 4. rake test:debian:emacs28 
>
> -- 
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at <https://orgmode.org/>.
> Support Org development at <https://liberapay.com/org-mode>,
> or support my work at <https://liberapay.com/yantar92>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#60626: 30.0.50; `buffer-live-p' sometimes returns t on killed buffers
>
>
>
>
> Date: 
>
> Wed, 11 Jan 2023 14:50:40 +0200
>
>
>
>
> > From: Ihor Radchenko <yantar92@posteo.net>
> > Cc: Eli Zaretskii <eliz@gnu.org>, 60626@debbugs.gnu.org
> > Date: Wed, 11 Jan 2023 11:08:04 +0000
> > 
> > Michael Heerdegen <michael_heerdegen@web.de> writes:
> > 
> > > Couldn't it be that the buffer had been live when the form had been
> > > evaluated, but killed when the form had been printed (later)?  The
> > > information you posted does not necessarily imply that `buffer-live-p'
> > > ever returned t when called with a killed buffer.
> > 
> > This is likely true.
> > 
> > The test looks like
> > 
> > (unwind-protect
> >         (org-test-with-temp-text
> >           (format "#+begin_src octave :results file graphics :file %s
> > sombrero;
> > #+end_src"
> >                   file)
> >           (org-babel-execute-src-block)
> >           (should (search-forward (format "[[file:%s]]" file) nil nil))
> >           (should (file-readable-p file))
> >           (should-not (buffer-live-p (get-buffer "*Org-Babel Error 
> > Output*"))))
> >       ;; clean-up
> >       (delete-file file)
> >       (when (get-buffer "*Org-Babel Error Output*")
> >         (kill-buffer "*Org-Babel Error Output*")))
> > 
> > So, unwind fallback forms are likely executed.
> > 
> > Thanks for the pointer!
> > 
> > I think this bug report can then be closed.
>
> Thanks, closing.
>
>
> --- End Message ---