bug#60666: closed (30.0.50; [PATCH] Use field properties in Eshell buffers)

[GNU bug Tracking System]

Your message dated Sat, 14 Jan 2023 11:30:59 -0800
with message-id <46d75af6-4de8-0724-f655-f3855936773a@gmail.com>
and subject line Re: bug#60666: 30.0.50; [PATCH] Use field properties in Eshell 
buffers
has caused the debbugs.gnu.org bug report #60666,
regarding 30.0.50; [PATCH] Use field properties in Eshell buffers
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
60666: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60666
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: 30.0.50; [PATCH] Use field properties in Eshell buffers Date: Sun, 8 Jan 2023 15:34:03 -0800 This was prompted by a small annoyance I noticed in Eshell. When entering a command in an Eshell buffer, "C-a" takes you to the beginning of your input, but the Home key takes you all the way to the beginning of the line (so that the point is located within the the actual prompt text).

After digging through the Eshell code, I realized that this was because Eshell binds C-a to 'eshell-bol', but doesn't do the same for Home. The easiest way to fix this would be to add a binging for Home. However, when comparing this code to that of 'M-x shell', I noticed that the latter uses field properties to delimit parts of the shell buffer so that things Just Work. I think that's a more-robust way of doing things, and it would be nice to make Eshell do the same.

Attached are some patches to do this. Aside from the user-facing change that the Home key works like C-a now, this also means that users don't have to set 'eshell-prompt-regexp' anymore (unless they want to use paragraph navigation, that is). In fact, maybe it would be better to map M-{ and M-} to 'eshell-prompt-(previous|next)'. That would have the same effect as '(backward|forward)-paragraph' (I think), but it would be more robust.

Any thoughts here?

0001-Set-the-field-property-for-Eshell-output.patch
Description: Text document

0002-Make-eshell-bol-obsolete.patch
Description: Text document

0003-Use-the-field-property-to-navigate-through-Eshell-pr.patch
Description: Text document

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#60666: 30.0.50; [PATCH] Use field properties in Eshell buffers
>
>
>
>
> Date: 
>
> Sat, 14 Jan 2023 11:30:59 -0800
>
>
>
>
> On 1/13/2023 5:07 AM, Eli Zaretskii wrote:
> > Thanks, I'm happy now.
>
> Thanks. I've merged this as c257fd3a406d6aa83be60b96217e42b49b62cf5f. 
> Closing this bug now.
>
>
> --- End Message ---