bug#60802: closed ([PATCH 0/2] Remove unsupported u-boot-malta package)

[GNU bug Tracking System]

Your message dated Wed, 18 Jan 2023 20:55:59 -0500
with message-id <87h6wne18w.fsf_-_@gmail.com>
and subject line Re: bug#60802: [PATCH 0/2] Remove unsupported u-boot-malta 
package
has caused the debbugs.gnu.org bug report #60802,
regarding [PATCH 0/2] Remove unsupported u-boot-malta package
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
60802: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60802
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/2] Remove unsupported u-boot-malta package
>
>
>
>
> Date: 
>
> Fri, 13 Jan 2023 22:05:39 -0500
>
>
>
>
> The package was causing issues when migrating the make-u-boot-package
> procedure to use Guix's infrastructure for cross-compilation, because Guix
> would now attempt to build a cross-compiler for mips64el, which is not
> supported per (guix platforms).
>
>
> Maxim Cournoyer (2):
>   platforms: Raise an exception when no suitable platform is found.
>   gnu: Remove u-boot-malta.
>
>  gnu/packages/bootloaders.scm |  3 ---
>  gnu/packages/bootstrap.scm   |  2 +-
>  guix/platform.scm            | 44 ++++++++++++++++++++++++++----------
>  3 files changed, 33 insertions(+), 16 deletions(-)
>
>
> base-commit: 4913ac74915c4229aeb3ca26a5f9920c759fb6a3
> -- 
> 2.38.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#60802: [PATCH 0/2] Remove unsupported u-boot-malta package
>
>
>
>
> Date: 
>
> Wed, 18 Jan 2023 20:55:59 -0500
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
>
>
>
>
> Hello,
>
> Ludovic Courtès <ludo@gnu.org> writes:
>
> > Hi,
> >
> > Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
> >
> >> This was motivated by #60786, which produced a cryptic, hard to understand
> >> backtrace.
> >>
> >> * guix/platform.scm (&platform-not-found-error): New exception type.
> >> (make-platform-not-found-error): New exception constructor.
> >> (platform-not-found-error?): New predicate.
> >> (false-if-platform-not-found): New syntax.
> >> (lookup-platform-by-system): Raise an exception when no platform is found.
> >> Update documentation.
> >> (lookup-platform-by-target): Likewise.
> >> (lookup-platform-by-target-or-system): Likewise, and guard lookup calls with
> >> false-if-platform-not-found.
> >
> > Sounds like a good idea!
> >
> >> +++ b/guix/platform.scm
> >> @@ -21,6 +21,7 @@ (define-module (guix platform)
> >>    #:use-module (guix memoization)
> >>    #:use-module (guix records)
> >>    #:use-module (guix ui)
> >> +  #:use-module (ice-9 exceptions)
> >
> > So far the we use (srfi srfi-35) exclusively to define condition types;
> > I think we should do the same here, for consistency.
> >
> >> +            &platform-not-found-error
> >> +            make-platform-not-found-error
> >
> > The constructor doesn’t need to be exposed.
> >
> >> +;;;
> >> +;;; Exceptions.
> >> +;;;
> >> +(define-exception-type &platform-not-found-error &error
> >> +  make-platform-not-found-error platform-not-found-error?)
> >
> > So this would become (define-condition-type …).
> >
> > Otherwise LGTM, thanks!
>
> The latest version incorporate these changes and use srfi-34/35 as is
> currently custom in Guix.
>
> I've now applied it.
>
> -- 
> Thanks,
> Maxim
>
>
> --- End Message ---