bug#61065: closed ([PATCH] gnu: Add emacs-ein.)

[GNU bug Tracking System]

Your message dated Fri, 27 Jan 2023 23:08:48 +0100
with message-id <87v8krk4un.fsf@nicolasgoaziou.fr>
and subject line Re: [bug#61065] [PATCH v2] gnu: Add emacs-ein.
has caused the debbugs.gnu.org bug report #61065,
regarding [PATCH] gnu: Add emacs-ein.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
61065: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61065
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: Add emacs-ein.
>
>
>
>
> Date: 
>
> Wed, 25 Jan 2023 21:12:36 +0100
>
>
>
>
> * gnu/packages/emacs-xyz.scm (emacs-ein): New variable.
> ---
>  gnu/packages/emacs-xyz.scm | 42 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index dc378581f5..30633bd52c 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -34326,6 +34326,48 @@ (define-public emacs-code-cells
>  execute code split into cells according to certain magic comments.")
>        (license license:gpl3+))))
>  
> +(define-public emacs-ein
> +  (package
> +    (name "emacs-ein")
> +    (version "20220911")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri
> +        (git-reference
> +         (url "https://github.com/millejoh/emacs-ipython-notebook";)
> +         (commit "b2410dc96f61aa806a7934099d8f1e40c8f6ca18")))
> +       (sha256
> +        (base32
> +         "02392bxl0msda58cls0i79mzqjs73x39czx0mlb0sg2vxp84gy15"))))
> +    (build-system emacs-build-system)
> +    (arguments
> +     (list #:phases
> +           #~(modify-phases %standard-phases
> +               (add-after 'unpack 'move-source-files
> +                 (lambda _
> +                   (let ((el-files (find-files "./lisp" ".*\\.el$")))
> +                     (for-each (lambda (f)
> +                                 (rename-file f (basename f)))
> +                               el-files)))))))
> +    (propagated-inputs (list emacs-websocket
> +                             emacs-anaphora
> +                             emacs-request
> +                             emacs-deferred
> +                             emacs-polymode
> +                             emacs-dash
> +                             emacs-with-editor))
> +    (home-page "https://github.com/millejoh/emacs-ipython-notebook";)
> +    (synopsis "Jupyter client for all languages")
> +    (description
> +     "The Emacs IPython Notebook (EIN) package provides a Jupyter Notebook
> +client and integrated REPL (like SLIME) in Emacs.  EIN improves notebook
> +editing by allowing you to use Emacs.  It also expose IPython features such as
> +code evaluation, object inspection and code completion. These features can be
> +accessed anywhere in Emacs and improve Python code editing and reading in
> +general in Emacs.")
> +    (license license:gpl3+)))
> +
>  (define-public emacs-kibit-helper
>    (package
>      (name "emacs-kibit-helper")
>
> base-commit: 968b882f55c4d1009e62c603a860edfaee1609ad
> -- 
> 2.39.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#61065] [PATCH v2] gnu: Add emacs-ein.
>
>
>
>
> Date: 
>
> Fri, 27 Jan 2023 23:08:48 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
>
>
>
>
> Hello,
>
> Cayetano Santos via Guix-patches via <guix-patches@gnu.org> writes:
>
> > * gnu/packages/emacs-xyz.scm (emacs-ein): New variable.
>
> Thank you. I applied your patch with the following changes.
>
>
> > +(define-public emacs-ein
> > +  (package
> > +    (name "emacs-ein")
> > +    (version "20220911")
> > +    (source
> > +     (origin
> > +       (method git-fetch)
> > +       (uri
> > +        (git-reference
> > +         (url "https://github.com/millejoh/emacs-ipython-notebook";)
> > +         (commit "b2410dc96f61aa806a7934099d8f1e40c8f6ca18")))
>
> I added
>
>   (file-name (git-file-name name version))
>
> > +       (sha256
> > +        (base32
> > +         "02392bxl0msda58cls0i79mzqjs73x39czx0mlb0sg2vxp84gy15"))))
> > +    (build-system emacs-build-system)
> > +    (arguments
> > +     (list
> > +      #:tests? #t
> > +      #:test-command
> > +      #~(list "emacs" "-Q" "--batch"
> > +              "-L" "test"
> > +              "--load" "test/testein-loader.el")
> > +      #:phases
> > +           #~(modify-phases %standard-phases
> > +               (add-after 'unpack 'move-source-files
> > +                 (lambda _
> > +                   (let ((el-files (find-files "./lisp" ".*\\.el$")))
> > +                     (for-each (lambda (f)
> > +                                 (rename-file f (basename f)))
> > +                               el-files)))))))
> > +    (native-inputs
> > +     (list emacs-f emacs-mocker))
> > +    (propagated-inputs (list emacs-anaphora
> > +                             emacs-dash
> > +                             emacs-deferred
> > +                             emacs-polymode
> > +                             emacs-request
> > +                             emacs-websocket
> > +                             emacs-with-editor))
>
> I added a newline character after "propagated-inputs".
>
> > +    (home-page "https://github.com/millejoh/emacs-ipython-notebook";)
> > +    (synopsis "Jupyter client for all languages")
> > +    (description
> > +     "The Emacs IPython Notebook (EIN) package provides a Jupyter Notebook
> > +client and integrated REPL (like SLIME) in Emacs.  EIN improves notebook
> > +editing by allowing you to use Emacs.  It also expose IPython features such 
> > as
> > +code evaluation, object inspection and code completion. These features can be
>
> I added a missing space before "These features".
>
> Regards,
> -- 
> Nicolas Goaziou
>
>
> --- End Message ---