[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#61570: closed (Backward incompatible changes in mpd-service-type)

From: GNU bug Tracking System
Subject: bug#61570: closed (Backward incompatible changes in mpd-service-type)
Date: Sun, 02 Apr 2023 14:43:02 +0000

Your message dated Sun, 2 Apr 2023 15:42:24 +0100
with message-id <f17a6175-8fd6-0512-0570-e118de71d1fb@makinata.eu>
and subject line control-msg
has caused the debbugs.gnu.org bug report #61570,
regarding Backward incompatible changes in mpd-service-type
to be marked as done.

(If you believe you have received this mail in error, please contact

61570: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61570
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: Backward incompatible changes in mpd-service-type Date: Fri, 17 Feb 2023 07:53:48 -0500

I wanted to note some findings regarding the improved
mpd-configuration/mdp-service-type (thanks!)
(5c5f0fc1135ff15f9c4adfc5f27eadd9a592b5d1, "services: mpd: Refactor MPD
service.") after having reconfigured my machine yesterday.  I've noted
these two backward incompatible changes:

1. the mixer type must now be a string instead of a symbol, and takes
"none" instead of 'null for the null mixer:

--8<---------------cut here---------------start------------->8---
@@ -239,7 +239,7 @@
                         (name "streaming")
                         (type "httpd")
-                        (mixer-type 'null)
+                        (mixer-type "none")
                          `((encoder . "lame")
                            (port    . "6601")
--8<---------------cut here---------------end--------------->8---

It'd be nice if there was some deprecation warning and automatic healing
code for now.  The doc should also be updated, because it still mention
the @code{null} value:

--8<---------------cut here---------------start------------->8---
     ‘mixer-type’ (default: ‘"none"’) (type: string)
          This field accepts a string that specifies which mixer should
          be used for this audio output: the ‘hardware’ mixer, the
          ‘software’ mixer, the ‘null’ mixer (allows setting the volume,
          but with no effect; this can be used as a trick to implement
          an external mixer External Mixer) or no mixer (‘none’).
--8<---------------cut here---------------end--------------->8---

2.  The MPD user appears to be created instead of using an existing
one.  I was using my own account, like this:

--8<---------------cut here---------------start------------->8---
      (service mpd-service-type
                (user "maxim")
                (address "")
                 (list (mpd-output)
                        (name "streaming")
                        (type "httpd")
                        (mixer-type "none")
                         `((encoder . "lame")
                           (port    . "6601")
                           (bitrate . "320"))))))))
--8<---------------cut here---------------end--------------->8---

and 'guix system reconfigure' is now warning that a user is defined
twice, and my user description following reconfiguration is: "Music
Player Daemon (MPD) user" :-).

Perhaps it should check if a user already exists and not add it if it
does?  Else an error rather than a warning when multiple same-name users
are defined would be more appropriate, I think.


--- End Message ---
--- Begin Message --- Subject: control-msg Date: Sun, 2 Apr 2023 15:42:24 +0100 User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1
Done with 7fdadeac11a997583305cb867b4a8828808ae953.

--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]