bug#73011: closed ([PATCH] gnu: go-github-com-elliotchance-orderedmap: Fix tests.)

[GNU bug Tracking System]

Your message dated Wed, 04 Sep 2024 10:15:34 +0100
with message-id <87ttevye2x.fsf@gmail.com>
and subject line [PATCH] gnu: go-github-com-elliotchance-orderedmap: Fix tests.
has caused the debbugs.gnu.org bug report #73011,
regarding [PATCH] gnu: go-github-com-elliotchance-orderedmap: Fix tests.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
73011: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73011
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: go-github-com-elliotchance-orderedmap: Fix tests.
>
>
>
>
> Date: 
>
> Tue,  3 Sep 2024 21:27:47 +0000
>
>
>
>
> * gnu/packages/golang-xyz.scm (go-github-com-elliotchance-orderedmap)
> [arguments]<#:phases>: Replace 'check and only run short tests so as to
> exclude flaky performance tests.
>
> Change-Id: If9fbc5510643f9d5e3ccff09f71e00a9cdfbe92f
> ---
>  gnu/packages/golang-xyz.scm | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/golang-xyz.scm b/gnu/packages/golang-xyz.scm
> index 796341a66bc..6c17d0a74b9 100644
> --- a/gnu/packages/golang-xyz.scm
> +++ b/gnu/packages/golang-xyz.scm
> @@ -2154,7 +2154,15 @@ (define-public go-github-com-elliotchance-orderedmap
>          (base32 "1hhyk96l6mfijkay9ga6jqpczpn34fbqkjrqj3v9pf5p1hzd0xdx"))))
>      (build-system go-build-system)
>      (arguments
> -     (list #:import-path "github.com/elliotchance/orderedmap"))
> +     (list #:import-path "github.com/elliotchance/orderedmap"
> +           #:phases
> +           #~(modify-phases %standard-phases
> +               (replace 'check
> +                 (lambda* (#:key tests? import-path #:allow-other-keys)
> +                   (when tests?
> +                     ;; The full test suite runs flaky performance tests,
> +                     ;; so only run the short tests.
> +                     (invoke "go" "test" "-test.short" import-path)))))))
>      (native-inputs
>       (list go-github-com-stretchr-testify))
>      (home-page "https://github.com/elliotchance/orderedmap";)
>
> base-commit: 19e0b937857563e77841a4fc5433589fa98c810d
> -- 
> 2.46.0
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: [PATCH] gnu: go-github-com-elliotchance-orderedmap: Fix tests. Date: Wed, 04 Sep 2024 10:15:34 +0100

Hi Greg,

Thanks for the patch.

I've applied minor modification to the patch to make sure "v2" inherits
replaced check phase as well.

Pushed as 5b841a42fbf3ffd929ba76e37753ba1cb4797125 to master.

--
Oleg

signature.asc
Description: PGP signature

--- End Message ---