emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#71793: closed ([PATCH] ui: Write down the unwritten rule.)


From: GNU bug Tracking System
Subject: bug#71793: closed ([PATCH] ui: Write down the unwritten rule.)
Date: Wed, 04 Sep 2024 13:58:01 +0000

Your message dated Wed, 04 Sep 2024 15:56:12 +0200
with message-id <87o753cykj.fsf@gnu.org>
and subject line Re: [bug#71793] [PATCH] ui: Write down the unwritten rule.
has caused the debbugs.gnu.org bug report #71793,
regarding [PATCH] ui: Write down the unwritten rule.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
71793: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71793
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [PATCH] ui: Write down the unwritten rule. Date: Thu, 27 Jun 2024 13:44:10 +0200
Quote from Ludovic:

> [..] there’s the unwritten rule that non-UI modules should not load (guix
> ui) [..]

This commit turns it into a written rule.

* guix/ui.scm: Document the import policy.

Change-Id: Iedd48f5622b2b17b9e2eec817cf27f0c3a938ff2
---
 guix/ui.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/guix/ui.scm b/guix/ui.scm
index d82fa533cc..d24886d156 100644
--- a/guix/ui.scm
+++ b/guix/ui.scm
@@ -35,6 +35,10 @@
 ;;; You should have received a copy of the GNU General Public License
 ;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
 
+;;; !!!!
+;;; !!!! This module shall not be imported from non-UI modules.
+;;; !!!!
+
 (define-module (guix ui)
   #:use-module (guix i18n)
   #:use-module (guix colors)
-- 
2.45.1




--- End Message ---
--- Begin Message --- Subject: Re: [bug#71793] [PATCH] ui: Write down the unwritten rule. Date: Wed, 04 Sep 2024 15:56:12 +0200 User-agent: Gnus/5.13 (Gnus v5.13)
Hi,

Tomas Volf <~@wolfsden.cz> skribis:

> Quote from Ludovic:
>
>> [..] there’s the unwritten rule that non-UI modules should not load (guix
>> ui) [..]
>
> This commit turns it into a written rule.
>
> * guix/ui.scm: Document the import policy.
>
> Change-Id: Iedd48f5622b2b17b9e2eec817cf27f0c3a938ff2

I committed a variant of this patch, thanks.

Ludo’.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]